Skip to content

Conversation

@TharakaUJ
Copy link
Contributor

introduce automated security scanning for dependencies by running npm audit in pull requests. this ensures vulnerabilities are caught earlier in the development cycle and increases visibility for reviewers.

Closes #153

Purpose

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@TharakaUJ TharakaUJ closed this Sep 24, 2025
@TharakaUJ TharakaUJ reopened this Sep 24, 2025
introduce automated security scanning for dependencies by running `npm audit` in pull requests.
this ensures vulnerabilities are caught earlier in the development cycle and increases visibility for reviewers.

Closes asgardeo#153
@brionmario
Copy link
Member

Hi @TharakaUJ,

Thanks a lot for the PR.

Just FYI, jave a look at here: #153 (comment) to understand the issue picking process of the competition.

Cheers!

@brionmario
Copy link
Member

@NipuniBhagya Could you please review this?

@TharakaUJ
Copy link
Contributor Author

Just FYI, jave a look at here: #153 (comment) to understand the issue picking process of the competition.

Thanks for pointing me to that! I’ve gone through the comment and now understand the issue picking process. I’ll be sure to follow it properly for future contributions.

TharakaUJ

This comment was marked as duplicate.

@TharakaUJ TharakaUJ requested a review from brionmario October 8, 2025 20:07
strategy:
matrix:
node-version: [lts/*]
steps:
Copy link
Member

@brionmario brionmario Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets replace the existing steps with the existing steps from https://github.com/asgardeo/javascript/blob/main/.github/workflows/pr-builder.yml#L23C1-L66 apart from 🐳 Set SHAs for Nx.

Suggested change
steps:
steps:
- name: ⬇️ Checkout
id: checkout
uses: actions/[email protected]

@asgardeo asgardeo deleted a comment from JayaShakthi97 Oct 17, 2025
Follow the current style of configuring CI jobs as requested by reviewers:

- Use matrix strategy for Node.js versions for ease of maintenance
- Match the exact same style as reference pr-builder.yml workflow

Addresses reviewer feedback: "Lets follow the current style of configuring CI jobs.
We usually keep a matrix of the versions such as Node.js for ease."
@asgardeo-github-bot
Copy link

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

@brionmario
Copy link
Member

@TharakaUJ,

Awesome work.
Merging this now.

Thanks for the contribution.

@brionmario brionmario merged commit 6e1d34a into asgardeo:main Oct 27, 2025
4 of 6 checks passed
@TharakaUJ
Copy link
Contributor Author

Happy to contribute.
Thank you too for guiding!

@TharakaUJ TharakaUJ deleted the npm-audit branch December 1, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: add security scanner to PR builder for NPM audit log

3 participants