-
Notifications
You must be signed in to change notification settings - Fork 33
feat(tanstack-router): implement @asgardeo/tanstack-router
with <ProtectedRoute /> for auth-guarded routes
#176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey @d3varaja, Thanks alot for the PR. There seems to be some failures due to Additionally, shall we do the following tasks as well:
The samples should be:
Note We may have to restructure the current structure to include both router options. i.e |
hi @brionmario, i created a pr for the documentation update at wso2/docs-is#5607 please feel free to check it out thanks! |
@asgardeo/tanstack-router
with <ProtectedRoute /> for auth-guarded routes
Cool. Will check 🙌 Shall we work on the sample as well? |
working on it right now, will push in a bit |
Initial implementation of @asgardeo/tanstack-router, providing a ProtectedRoute component for route protection with authentication checks in TanStack Router-based React applications. Includes configuration, documentation, tests, build setup, and TypeScript support.
Co-authored-by: Brion Mario <[email protected]>
Introduces a comprehensive test suite for the ProtectedRoute component, covering scenarios for authentication, loading state, fallback and redirect behavior, and error handling. This improves test coverage and ensures correct behavior under various conditions.
Introduced a new sample application under samples/react-tanstack-router demonstrating integration of Asgardeo authentication with TanStack Router in a React app. Updated the TanStack Router package README to reference the new sample. Added related configuration, source files, and dependencies.
014df30
to
3aa740d
Compare
@brionmario pushed the sample application, feel free to look at it when you have some time, thanks |
Great! Meantime, lets do the following:
|
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
Add lockfile entries for newly added i18n package dependencies including build tools, linting, and testing packages
hi @brionmario, i updated the lock file which was causing the ci/cd issues and also add the change set, let me know if there is any issues with them, thanks! :) |
Initial implementation of @asgardeo/tanstack-router, providing a for TanStack Router. This enables auth-guarded routes with Asgardeo, removing the need for manual useAsgardeo wiring and aligning with the DX of @asgardeo/react-router.
Purpose
@asgardeo/tanstack-router package
for route protection #152).Related Issues
@asgardeo/tanstack-router package
for route protection #152Checklist
Security checks