Skip to content

Conversation

navidik
Copy link

@navidik navidik commented Oct 2, 2025

Purpose

Add Tamil (ta-IN) language support to the @asgardeo/i18n package for better accessibility for Tamil-speaking users.

Related Issues

Fixes chore: add தமிழ் - ta-IN language support #164
Related PRs

None
Checklist

e2e cypress tests locally verified.
Manual test round performed and verified.
UX/UI review done on the final implementation.
Documentation provided. (Add links if there are any)
Unit tests provided. (Add links if there are any)
Integration tests provided. (Add links if there are any)
Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines?
Ran FindSecurityBugs plugin and verified report?
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?

pavinduLakshan
pavinduLakshan previously approved these changes Oct 3, 2025
Copy link
Contributor

@pavinduLakshan pavinduLakshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @navidik!

@brionmario could you also please take a look? Thanks in advance!

@pavinduLakshan
Copy link
Contributor

Let's add a changeset to this PR. You can refer to https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#releases on how to generate a changeset.

@brionmario
Copy link
Member

LGTM @navidik!

@brionmario could you also please take a look? Thanks in advance!

@navidik

Shall we move the file to the new @asgardeo/i18n package?

Refer: https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#contributing-to-the-internalization-i18n-package

@navidik
Copy link
Author

navidik commented Oct 4, 2025

LGTM @navidik!
@brionmario could you also please take a look? Thanks in advance!

@navidik

Shall we move the file to the new @asgardeo/i18n package?

Refer: https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#contributing-to-the-internalization-i18n-package

LGTM @navidik!
@brionmario could you also please take a look? Thanks in advance!

@navidik

Shall we move the file to the new @asgardeo/i18n package?

Refer: https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#contributing-to-the-internalization-i18n-package

is the new @asgardeo/i18n package is exists or wanna create ?

@pavinduLakshan
Copy link
Contributor

is the new @asgardeo/i18n package is exists or wanna create ?

New i18n package is now available in the main branch[1]. You just need to add your translation file to it.

[1] https://github.com/asgardeo/javascript/tree/main/packages/i18n

@asgardeo-github-bot
Copy link

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

@brionmario
Copy link
Member

brionmario commented Oct 5, 2025

Hey @navidik,

Shall we do the following tasks to make the PR complete:

  • Fix the ESLint issues:
Screenshot 2025-10-05 at 20 40 06

Reference PR: https://github.com/asgardeo/javascript/pull/188/files

@navidik
Copy link
Author

navidik commented Oct 5, 2025

Hey @navidik,

Shall we do the following tasks to make the PR complete:

  • Fix the ESLint issues:
Screenshot 2025-10-05 at 20 40 06 * Export the `ta-IN` from the `index.ts`: https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#contributing-to-the-internalization-i18n-package * Add a changeset: https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#creating-a-changeset * ⚠️ IMPORTANT: Follow our **[commit message guideline]**(https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#commit-message-guidelines)*
  • move the ta-IN.ts file to the new @asgardeo/i18n package is not a valid format.

Reference PR: https://github.com/asgardeo/javascript/pull/188/files

made changes and Pushed ,
check is it ok or not?

@brionmario
Copy link
Member

@navidik Could you please resolve the conflict as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants