-
Notifications
You must be signed in to change notification settings - Fork 33
feat(i18n): add Tamil (ta-IN) language support #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @navidik!
@brionmario could you also please take a look? Thanks in advance!
Let's add a changeset to this PR. You can refer to https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#releases on how to generate a changeset. |
Shall we move the file to the new |
is the new @asgardeo/i18n package is exists or wanna create ? |
New i18n package is now available in the main branch[1]. You just need to add your translation file to it. [1] https://github.com/asgardeo/javascript/tree/main/packages/i18n |
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
Hey @navidik, Shall we do the following tasks to make the PR complete:
![]()
Reference PR: https://github.com/asgardeo/javascript/pull/188/files |
made changes and Pushed , |
@navidik Could you please resolve the conflict as well? |
Purpose
Add Tamil (ta-IN) language support to the @asgardeo/i18n package for better accessibility for Tamil-speaking users.
Related Issues
Fixes chore: add
தமிழ் - ta-IN
language support #164Related PRs
None
Checklist
e2e cypress tests locally verified.
Manual test round performed and verified.
UX/UI review done on the final implementation.
Documentation provided. (Add links if there are any)
Unit tests provided. (Add links if there are any)
Integration tests provided. (Add links if there are any)
Security checks
Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines?
Ran FindSecurityBugs plugin and verified report?
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?