-
Notifications
You must be signed in to change notification settings - Fork 48
feat(react): add RTL support #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @d3varaja, Great work. High level comments:
And then use the
|
Introduces a new useRTL hook for detecting right-to-left (RTL) text direction and updates components and styles to use logical CSS properties for RTL compatibility. Adds tests for the useRTL hook and RTL support in BaseOrganizationSwitcher. Updates exports to include useRTL.
…con flipping - Add direction property to ThemePreferences interface (ltr/rtl) - Convert component styles to CSS logical properties - Implement icon flipping for RTL mode in OrganizationSwitcher - Add comprehensive RTL tests - Remove redundant useRTL hook (use useTheme instead)
76a757b to
ff1f698
Compare
|
Hi @brionmario, Thanks for the feedback! I've addressed your comments, All feedback has been addressed:
The CI lint failures appear to be pre-existing on main and unrelated to the RTL changes LRT Version
RTL Verision
|
e7394ab to
ff1f698
Compare
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
|
Hey @d3varaja, Thanks for the contribution. Cheers! |


Introduces a new
useRTLReact hook to detect right-to-left (RTL) text direction and enhance component compatibility for RTL layouts.Updates components and styles to use logical CSS properties for consistent behavior across LTR and RTL contexts.
Adds test coverage for the
useRTLhook and verifies RTL functionality inBaseOrganizationSwitcher.Exports the new hook in the React package for developer use.
Purpose
Provide consistent right-to-left language support across Asgardeo React components and enable dynamic RTL detection through a reusable hook.
Related Issues
RTLsupport for@asgardeo/react&@asgardeo/nextjsUI components #144Related PRs
N/A
Checklist
Security Checks
Package Affected
@asgardeo/reactChangeset