Skip to content

Conversation

@brionmario
Copy link
Member

Purpose

This pull request focuses on improving type safety and consistency across both the JavaScript and React packages. The main changes include stricter typing for component configs and models, updates to workflow files to support matrix-based pnpm versioning, and enhancements to SDK response types.

Type Safety and Model Improvements

  • Updated various component adapters in packages/react/src/components/adapters/ to use explicit type casting for config values, ensuring more reliable and predictable type usage throughout form field rendering. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]
  • Updated model interfaces in packages/javascript/src/models/ to use more precise types (e.g., making clientId optional, refining config and type fields, and extending the sign-in flow response structure). [1] [2] [3]

SDK and API Enhancements

  • The signIn method in AsgardeoReactClient now returns either a User or the new EmbeddedSignInFlowResponseV2 type, supporting richer SDK-level responses. [1] [2]

Workflow and CI Improvements

  • Updated GitHub workflow files (.github/workflows/pr-builder.yml and .github/workflows/npm-audit.yml) to use a matrix for pnpm-version, improving flexibility and future-proofing CI for dependency management. [1] [2] [3] [4] [5] [6] [7]

Release Documentation

  • Added a changeset file documenting the patch release for both @asgardeo/javascript and @asgardeo/react, summarizing the type safety improvements.

Related Issues

Related PRs

  • N/A

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

@asgardeo-github-bot
Copy link

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit 8b588c8 into asgardeo:main Oct 29, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants