Skip to content

Conversation

@brionmario
Copy link
Member

Purpose

This pull request refines how input fields are transformed into UI components for both the sign-in and sign-up flows. The main change is shifting the logic for determining input variants to rely solely on the input type, with a workaround added to handle password fields when their type is incorrectly specified as "string". This improves consistency and prepares for future improvements.

Input variant determination logic:

  • Updated getInputVariant in both SignIn and SignUp transformers to use only the input type for deciding the component variant, removing checks based on the field name. [1] [2]

Password field handling workaround:

  • In both convertSimpleInputToComponent functions, added logic to set the field type to "password" if the field name contains "password" and the type is "string", ensuring correct handling of password fields until a broader fix is implemented. [1] [2]

Related Issues

Related PRs

  • N/A

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

@asgardeo-github-bot
Copy link

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit e821917 into asgardeo:main Nov 11, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants