chore(vue): initialize vue.js sample app #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recipes/vue-vite/README.md
Outdated
| @@ -0,0 +1,45 @@ | |||
| # vue-vite | |||
|
|
|||
| This template should help get you started developing with Vue 3 in Vite. | |||
Contributor
There was a problem hiding this comment.
Let's update the readme to match the sample app
recipes/vue-vite/index.html
Outdated
| <meta charset="UTF-8" /> | ||
| <link rel="icon" href="/favicon.ico" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Vite App</title> |
recipes/vue-vite/package.json
Outdated
| @@ -0,0 +1,42 @@ | |||
| { | |||
| "name": "vue-vite", | |||
recipes/vue-vite/README.md
Outdated
| ## Getting Started | ||
|
|
||
| ### Prerequisites | ||
| - `Node.js` (version 10 or above). |
Contributor
There was a problem hiding this comment.
Node 18 reaches EOL on April, 2025. Therefore no point in mentioning 10 (Vite and PNPM wouldn't even run on node v10). Let's update this to v20 or above.
recipes/vue-vite/README.md
Outdated
|
|
||
| ## Contribute | ||
|
|
||
| Please read [Contributing to the Code Base](http://wso2.github.io/) for details on our code of conduct, and the process for submitting pull requests to us. |
Contributor
There was a problem hiding this comment.
Let's point to CONTRIBUTING.md in repo root.
recipes/vue-vite/README.md
Outdated
|
|
||
| ### Reporting Issues | ||
|
|
||
| We encourage you to report issues, improvements, and feature requests by creating [Github Issues](https://github.com/asgardeo/asgardeo-auth-vue-sdk/issues). |
Contributor
There was a problem hiding this comment.
url should be https://github.com/asgardeo/web-ui-sdks/issues
recipes/vue-vite/eslint.config.ts
Outdated
| name: 'app/files-to-lint', | ||
| files: ['**/*.{ts,mts,tsx,vue}'], | ||
| }, | ||
|
|
Contributor
There was a problem hiding this comment.
Let's use asgardeo icon
Contributor
There was a problem hiding this comment.
Let's use asgardeo logo
recipes/vue-vite/vite.config.ts
Outdated
| import vue from '@vitejs/plugin-vue' | ||
| import vueDevTools from 'vite-plugin-vue-devtools' | ||
|
|
||
| // https://vite.dev/config/ |
Contributor
There was a problem hiding this comment.
Suggested change
| // https://vite.dev/config/ |
recipes/vue-vite/package.json
Outdated
| "jsdom": "^26.0.0", | ||
| "npm-run-all2": "^7.0.2", | ||
| "prettier": "^3.5.1", | ||
| "typescript": "~5.7.3", |
Contributor
There was a problem hiding this comment.
Let's update the TS version to workspace version
recipes/vue-vite/tsconfig.node.json
Outdated
| "compilerOptions": { | ||
| "noEmit": true, | ||
| "tsBuildInfoFile": "./node_modules/.tmp/tsconfig.node.tsbuildinfo", | ||
|
|
| "exclude": [], | ||
| "compilerOptions": { | ||
| "tsBuildInfoFile": "./node_modules/.tmp/tsconfig.vitest.tsbuildinfo", | ||
|
|
| @@ -0,0 +1,58 @@ | |||
| <!-- | |||
| * Copyright (c) 2025, WSO2 LLC. (https://www.wso2.com). | |||
Contributor
There was a problem hiding this comment.
Remove the boilerplate files. Check others files as well
pavinduLakshan
previously approved these changes
Mar 7, 2025
pavinduLakshan
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR initializes the Vue-Vite sample app with essential configurations:
Related Issues
Related PRs
Checklist
Security checks