Skip to content

Update default issuer helm value#2187

Merged
thiva-k merged 1 commit intoasgardeo:mainfrom
thiva-k:fix-helm-issuer
Apr 3, 2026
Merged

Update default issuer helm value#2187
thiva-k merged 1 commit intoasgardeo:mainfrom
thiva-k:fix-helm-issuer

Conversation

@thiva-k
Copy link
Copy Markdown
Contributor

@thiva-k thiva-k commented Apr 3, 2026

This pull request introduces a configuration option for the JWT issuer in the Helm chart values file. This allows users to optionally specify a custom issuer for JWT tokens, otherwise it will be derived from the server's URL.

Configuration improvements:

  • Added an optional issuer field under the jwt section in install/helm/values.yaml to allow explicit configuration of the JWT issuer. If not set, it defaults to being derived from the server's URL.

Summary by CodeRabbit

  • New Features
    • Added optional JWT issuer configuration setting during deployment. Users can now specify a custom JWT issuer value, which defaults to empty when unset.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e0d1239b-321d-4727-a43c-022617465ff2

📥 Commits

Reviewing files that changed from the base of the PR and between 0800a49 and 2c66058.

📒 Files selected for processing (1)
  • install/helm/values.yaml

📝 Walkthrough

Walkthrough

Added a new optional JWT issuer configuration parameter (configuration.jwt.issuer) to the Helm values file, defaulting to an empty string. This configuration value is derived automatically when unset.

Changes

Cohort / File(s) Summary
Helm Configuration
install/helm/values.yaml
Added new configuration.jwt.issuer configuration parameter with empty string default value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the purpose and approach, but is missing several required template sections including checklist items, security checks, and related issues/PRs. Complete the pull request description by adding the full checklist section, security checks, and confirming related issues/PRs status as shown in the template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: adding a JWT issuer configuration value to the Helm chart values file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.85%. Comparing base (0800a49) to head (2c66058).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2187   +/-   ##
=======================================
  Coverage   89.84%   89.85%           
=======================================
  Files         898      898           
  Lines       58937    58937           
=======================================
+ Hits        52951    52955    +4     
+ Misses       4420     4416    -4     
  Partials     1566     1566           
Flag Coverage Δ
backend-integration-postgres 53.91% <ø> (ø)
backend-integration-sqlite 53.90% <ø> (+0.03%) ⬆️
backend-unit 84.61% <ø> (+0.01%) ⬆️
frontend-apps-console-unit 90.41% <ø> (ø)
frontend-apps-gate-unit 97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thiva-k thiva-k enabled auto-merge April 3, 2026 18:25
@thiva-k thiva-k added this pull request to the merge queue Apr 3, 2026
Merged via the queue into asgardeo:main with commit bd21cd3 Apr 3, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants