Skip to content

Conversation

@wjrtz
Copy link
Contributor

@wjrtz wjrtz commented Jan 1, 2026

Hi there,

this PR adds support for bulk_destroy steps in Ash Reactor. I needed this and found it odd that, while bulk_create
and bulk_update were supported, bulk_destroy was still missing. So here it is. This PR was mostly AI generated. I tried to follow the existing implementation for bulk_update as closely as possible.

Let me know what you think. Thank you very much for maintaining Ash!

Kind regards,
Joshua

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

Adds support for `bulk_destroy` steps in Ash Reactor.
@zachdaniel zachdaniel requested a review from jimsynz January 1, 2026 21:05
jimsynz
jimsynz previously approved these changes Jan 11, 2026
Copy link
Contributor

@jimsynz jimsynz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BULK!

@zachdaniel
Copy link
Contributor

@wjrtz would you mind running mix check locally and addressing the failures? Otherwise LGTM 😄

@zachdaniel zachdaniel merged commit 113d305 into ash-project:main Jan 14, 2026
45 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants