Skip to content

fix: pass full context to Ash.load! in cascade changes #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimsynz merged 4 commits into from
Feb 8, 2026
+14 −14
Merged

fix: pass full context to Ash.load! in cascade changes #2537

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75ca83d
fix: pass full context to `Ash.load!` in cascade changes
jimsynz Jan 28, 2026
32ee606
fix: use scope option instead of to_opts for Ash.load! in cascade cha…
jimsynz Jan 29, 2026
8760e23
fix: avoid shadowing context variable in cascade changes
jimsynz Feb 1, 2026
d9b3462
fix: remove `authorize?: false` from cascade `Ash.load!` calls
jimsynz Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/ash/resource/change/cascade_destroy.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ defmodule Ash.Resource.Change.CascadeDestroy do

defp destroy_related([], _, _, _), do: :ok

defp destroy_related(data, opts, %{tenant: tenant} = context, changeset) do
defp destroy_related(data, opts, context, changeset) do
action = opts.action
relationship = opts.relationship

Expand Down Expand Up @@ -346,7 +346,8 @@ defmodule Ash.Resource.Change.CascadeDestroy do
|> List.wrap()
|> Ash.load!(
[{relationship.name, load_query}],
tenant: tenant
scope: context,
Copy link
Contributor

@stevebrambilla stevebrambilla Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up that this function rebinds context above:

ash/lib/ash/resource/change/cascade_destroy.ex

Lines 299 to 303 in 32ee606

context =
Map.merge(relationship.context || %{}, %{
cascade_destroy: true,
accessing_from: %{source: relationship.source, name: relationship.name}
})

So it's missing the tenant here now

Copy link
Contributor

@zachdaniel zachdaniel Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯 good call!

Copy link
Contributor

@zachdaniel zachdaniel Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not overwrite context in the first place to avoid this confusion.

authorize?: false
)
|> Enum.flat_map(fn record ->
record
Expand Down
5 changes: 3 additions & 2 deletions lib/ash/resource/change/cascade_update.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ defmodule Ash.Resource.Change.CascadeUpdate do

defp update_related(_, [], _, _), do: :ok

defp update_related(changeset, data, opts, %{tenant: tenant} = context) do
defp update_related(changeset, data, opts, context) do
action = opts.action
relationship = opts.relationship
copies = opts.copy_inputs
Expand Down Expand Up @@ -260,7 +260,8 @@ defmodule Ash.Resource.Change.CascadeUpdate do
|> List.wrap()
|> Ash.load!(
[{relationship.name, load_query}],
tenant: tenant
scope: context,
authorize?: false
)
|> Enum.flat_map(fn record ->
record
Expand Down