Skip to content

Change level of repetitive log #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachdaniel merged 4 commits into from
Jun 17, 2025
Merged

Change level of repetitive log #324

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a797272
Handle display of Postgrex range
capoccias Jun 15, 2025
76c4a1e
Add way to prevent logging error of Failed to display value
capoccias Jun 15, 2025
3d0092d
Remove config option to silence log and instead just log as debug
capoccias Jun 17, 2025
0ea412b
Improve matching of Postgrex.Range struct
capoccias Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions lib/ash_admin/components/resource/show.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ defmodule AshAdmin.Components.Resource.Show do
}>
{inspect(@calculation_errors[calculation.name])}
</.error>
<div class="px-4 py-3 text-right sm:px-6 text-right">
<div class="px-4 py-3 text-right sm:px-6">
<button
type="submit"
class="py-2 px-4 mt-2 bg-indigo-600 text-white border-gray-600 hover:bg-gray-400 rounded-md justify-center items-center"
Expand Down Expand Up @@ -910,6 +910,33 @@ defmodule AshAdmin.Components.Resource.Show do
end
end

defp value!(%{
__struct__: Postgrex.Range,
lower: lower,
upper: upper,
lower_inclusive: lower_inclusive,
upper_inclusive: upper_inclusive
}) do
lower_str =
case lower do
:unbound -> "-∞"
%DateTime{} = dt -> DateTime.to_string(dt)
other -> inspect(other)
end

upper_str =
case upper do
:unbound -> "+∞"
%DateTime{} = dt -> DateTime.to_string(dt)
other -> inspect(other)
end

lower_bracket = if lower_inclusive, do: "[", else: "("
upper_bracket = if upper_inclusive, do: "]", else: ")"

"#{lower_bracket}#{lower_str}, #{upper_str}#{upper_bracket}"
end

defp value!(value) do
data = Phoenix.HTML.Safe.to_iodata(value)

Expand All @@ -920,7 +947,7 @@ defmodule AshAdmin.Components.Resource.Show do
end
rescue
e ->
Logger.error("Failed to display value:\n#{Exception.format(:error, e, __STACKTRACE__)}")
Logger.debug("Failed to display value:\n#{Exception.format(:error, e, __STACKTRACE__)}")
"<display error>"
end

Expand Down