fix: only merge already-computed aggregates when select? is true #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a GROUP BY error introduced in bb458d5 where already-computed aggregates were being merged into the SELECT clause unconditionally. When aggregates filter on nested first aggregates the nested aggregate was incorrectly added to the SELECT clause in GROUP BY contexts, causing PostgreSQL grouping_error "column must appear in the GROUP BY clause or be used in an aggregate function" The fix adds a select? guard to only merge already-computed aggregates when we're in a select context. In internal subqueries with GROUP BY, aggregates remain available in bindings for FILTER clauses without being selected, avoiding the conflict. A test demonstrating the bug was added to ash_postgres/test/aggregate_test.exs test "multiple aggregates filtering on nested first aggregate"
zachdaniel
approved these changes
Nov 18, 2025
Contributor
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that occurred in our application when upgrading to the latest ash packanges, in particular
ash_sql. A PR with a test reproducing the issue was created on ash_postgres.Contributor checklist
Leave anything that you believe does not apply unchecked.