Skip to content

Upgrade vulkan headers to v1.4.341#1028

Draft
0xbeefd1ed wants to merge 2 commits intoash-rs:masterfrom
0xbeefd1ed:master
Draft

Upgrade vulkan headers to v1.4.341#1028
0xbeefd1ed wants to merge 2 commits intoash-rs:masterfrom
0xbeefd1ed:master

Conversation

@0xbeefd1ed
Copy link

@0xbeefd1ed 0xbeefd1ed commented Jan 25, 2026

Motivation

v1.4.341 is a high-impact Vulkan header release as it's the version that added VK_KHR_descriptor_heap. Changes in this PR are the minimal set to enable VK_EXT_descriptor_heap and to reduce potential conflict with any ongoing work.

Summary

  • Fix generator to handle internal feature splitting in newer Vulkan headers
  • Fix parameter filtering for comma-separated API attributes
  • Add missing derives to TransformMatrixKHR
  • Update AMDX shader enqueue wrappers for API changes
  • OpenHarmony types added to is_opaque_type() and platform_types.rs

Details

The Vulkan XML spec now splits commands across internal features (VK_BASE_VERSION_1_0, VK_COMPUTE_VERSION_1_0, VK_GRAPHICS_VERSION_1_0) with apitype="internal". Public features like VK_VERSION_1_0 depend on these internal features via the depends attribute instead of directly containing
commands.

The generator now pass in a map of all features so that we can recursively resolves dependencies when generating function pointer tables.

Test plan

  • cargo build succeeds
  • cargo test -p ash --lib passes (103 tests)
  • Generated tables have correct function pointers from resolved dependencies

@0xbeefd1ed 0xbeefd1ed changed the title Handle internal features and Vulkan 1.4 header changes Upgrade vulkan headers to v1.4.341 Jan 25, 2026
@0xbeefd1ed 0xbeefd1ed mentioned this pull request Jan 25, 2026
@0xbeefd1ed 0xbeefd1ed marked this pull request as draft January 25, 2026 11:29
@chrisprobst
Copy link

Please merge 🙏.

@0xbeefd1ed
Copy link
Author

0xbeefd1ed commented Jan 28, 2026

Marked as draft to indicate that this PR is unlikely to be merged by the maintainers. Feel free to use this branch in the meantime as an interim solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants