Upgrade vulkan headers to v1.4.341#1028
Draft
0xbeefd1ed wants to merge 2 commits intoash-rs:masterfrom
Draft
Conversation
Closed
|
Please merge 🙏. |
Author
|
Marked as draft to indicate that this PR is unlikely to be merged by the maintainers. Feel free to use this branch in the meantime as an interim solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
v1.4.341 is a high-impact Vulkan header release as it's the version that added VK_KHR_descriptor_heap. Changes in this PR are the minimal set to enable VK_EXT_descriptor_heap and to reduce potential conflict with any ongoing work.
Summary
TransformMatrixKHRis_opaque_type()andplatform_types.rsDetails
The Vulkan XML spec now splits commands across internal features (
VK_BASE_VERSION_1_0,VK_COMPUTE_VERSION_1_0,VK_GRAPHICS_VERSION_1_0) withapitype="internal". Public features likeVK_VERSION_1_0depend on these internal features via thedependsattribute instead of directly containingcommands.
The generator now pass in a map of all features so that we can recursively resolves dependencies when generating function pointer tables.
Test plan
cargo buildsucceedscargo test -p ash --libpasses (103 tests)