Open
Conversation
Ralith
approved these changes
Jun 8, 2024
Collaborator
Ralith
left a comment
There was a problem hiding this comment.
Not sure how useful this is in practice, but it seems like a strict improvement, and not too bad to maintain.
Collaborator
|
If we end up doing this, is there a lint that enables us to catch accidental/new remaining calls to Alternatively we could list such functions in
Might be neat, but if we do this we're better complete about it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a relatively simple but maybe controversial change.
In the functions that return a
Vec, instead of usingVec::with_capacityand similar, we useVec::new()followed withVec::try_reserve. Iftry_reservefails, we returnVK_ERROR_OUT_OF_HOST_MEMORY.Note that there's no shorter way on stable Rust to do this. Notably,
try_with_capacityis unstable.If I'm not mistaken, the bindings now never panic in case of OOM.
I personally don't have a need for this change, but I thought that this was a neat thing to add.