Fix default worktree location fallback#371
Open
qzchenwl wants to merge 1 commit intoasheshgoplani:mainfrom
Open
Fix default worktree location fallback#371qzchenwl wants to merge 1 commit intoasheshgoplani:mainfrom
qzchenwl wants to merge 1 commit intoasheshgoplani:mainfrom
Conversation
Owner
|
Thanks for the PR! However, this changes the default worktree location from 'subdirectory' to 'sibling' for all users who haven't explicitly set it. Our policy is that defaults must not change without a strong reason and migration plan. Could you either:
Happy to merge once the default behavior is preserved. |
Contributor
Author
|
Thanks, that’s fair. The main issue I was trying to address is that the current behavior and the published docs are inconsistent. Right now:
So the inconsistency is real; this PR chose to resolve it by aligning the implementation with the docs. If you want to preserve the current runtime behavior instead, then I think the right fix is to update the docs/template to consistently say |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
siblingsiblingdefault_locationTesting