Open
Conversation
✅ Deploy Preview for awesomeshapes ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mohittk
approved these changes
Jun 5, 2022
Sachin-chaurasiya
approved these changes
Jun 5, 2022
Collaborator
|
@ashutosh1919 , Please review once. |
ashutosh1919
requested changes
Jun 5, 2022
Owner
ashutosh1919
left a comment
There was a problem hiding this comment.
@essofyany why background shapes are scattered all over the place? why did you set zIndex=unset?
@Sachin-chaurasiya , @mohittk please don't merge until the shape positions are undone and the website looks same as the original one.
Contributor
Author
|
Hi there. in order to fix onHover issue which is caused by shape position (absolute/relative) also to its parent dimension, so to fix it I had to tweak other properties like z-index and suddenly this affects the positions of the shapes on the homepage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#85
Hi there I was working on this issue and I found out that to fix it I have to make some changes:
Please keep in mind that to change the color of Donut you have to change the border-color property and for CircleGrid you have to change the fill property and not the background.
For example: