Open
Conversation
added 2 commits
August 12, 2025 08:39
![isaac-asimov-bot[bot]](https://avatars.githubusercontent.com/in/1313072?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances profile support by adding numeric profile indices and implementing bookmark merging functionality. Users can now access profiles using simple numeric indices (e.g., /1, /2) instead of full profile names, and the system automatically merges bookmarks from all profiles when no specific profile is requested.
- Added numeric profile indexing system for easier profile access
- Implemented bookmark merging to combine results from multiple profiles
- Refactored Arc browser support to use the new numeric profile system
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/specialized/arc.rs | Added numeric profile mapping functions and duplicate conversion method |
| src/cataloger/main.rs | Added logic to skip transformation for already-processed JSON-LD content |
| src/browsers.rs | Implemented numeric profile support and bookmark merging across all browsers |
| src/bookmarks.rs | Added execute_multiple method to merge bookmarks from multiple profiles |
| README.md | Updated documentation to reflect new numeric profile syntax |
added 4 commits
August 12, 2025 21:57
…urn bookmarks by profile and without profile
There was a problem hiding this comment.
⚠️ CI failed
Show all
| Platform | Name | Status | Details |
|---|---|---|---|
| All | Formatting | ❌ | Details |
| Linux | Build library | ✅ | Details |
| Linux | Build library (no default features) | ⏩ | Details |
| Linux | Build binaries | ✅ | Details |
| Linux | Build tests | ✅ | Details |
| Linux | Build examples | ✅ | Details |
| Linux | Run tests | ✅ | Details |
| Linux | Run doctests | ✅ | Details |
| macOS | Build library | ✅ | Details |
| macOS | Build library (no default features) | ⏩ | Details |
| macOS | Build binaries | ✅ | Details |
| macOS | Build tests | ✅ | Details |
| macOS | Build examples | ✅ | Details |
| macOS | Run tests | ✅ | Details |
| macOS | Run doctests | ✅ | Details |
| Windows | Build library | ✅ | Details |
| Windows | Build library (no default features) | ⏩ | Details |
| Windows | Build binaries | ✅ | Details |
| Windows | Build tests | ✅ | Details |
| Windows | Build examples | ✅ | Details |
| Windows | Run tests | ✅ | Details |
| Windows | Run doctests | ✅ | Details |
=============================================
| Platform | Name | Status | Details |
|---|---|---|---|
| All | Formatting | ❌ | Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies profile selection by adding numeric profile support (e.g.,
/1,/2) and implements bookmark merging for multiple profiles.Changes
brave://bookmarks/1,brave://bookmarks/2instead of requiring full profile namesexecute_multiplemethod inBookmarksTransformto merge bookmarks from multiple profilesfetch_bookmarksto use the new merge functionality/Profile 1Now users can simply use numeric indices to access specific profiles, and when no index is specified (e.g.,
brave://bookmarks), all profiles are automatically merged into a single result.