[pull] master from dotansimha:master #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acters when transformUnderscore is true to emit valid Typescript syntax (#10412) * Add special handling for identifiers that consist entirely of _ when we are asked to remove underscores. Added a test for this behaviour as well. * Added changeset for change. * Revert "Add special handling for identifiers that consist entirely of _ when we are asked to remove underscores. Added a test for this behaviour as well." This reverts commit 3765f2a. * Added more tightly scoped behaviour and test for enums from Typescript specifically. * Update packages/plugins/other/visitor-plugin-common/src/base-types-visitor.ts Co-authored-by: Eddy Nguyen <[email protected]> --------- Co-authored-by: Eddy Nguyen <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )