Remove IChildProcess.IsSuccessful since it offers little functionality and is slightly vague.

Author: asmichi

src/ChildProcess.Test/ProcessManagement/ChildProcessExecutionTestUtil.cs

@@ -26,7 +26,7 @@ public static string ExecuteForStandardOutput(ChildProcessStartInfo si, Encoding
             var standardOutput = sr.ReadToEnd();
             p.WaitForExit();
 
-            if (!p.IsSuccessful)
+            if (p.ExitCode != 0)
             {
                 throw new ChildProcessFailedException($"Child process failed with exit code {p.ExitCode} (0x{p.ExitCode:X8}).");
             }

src/ChildProcess.Test/ProcessManagement/ChildProcessTest_Performance.cs

@@ -23,7 +23,7 @@ public void ChildProcessWaitForAsyncIsTrulyAsynchronous()
             using var sut = ChildProcess.Start(si);
             WaitForAsyncIsTrulyAsynchronous(sut);
             sut.WaitForExit();
-            Assert.True(sut.IsSuccessful);
+            Assert.Equal(0, sut.ExitCode);
         }
 
         private static void WaitForAsyncIsTrulyAsynchronous(IChildProcess sut)

src/ChildProcess.Test/ProcessManagement/ChildProcessTest_Redirection.cs

@@ -288,7 +288,7 @@ public void RedirectionToFile()
                 using (var sut = ChildProcess.Start(si))
                 {
                     sut.WaitForExit();
-                    Assert.True(sut.IsSuccessful);
+                    Assert.Equal(0, sut.ExitCode);
                 }
 
                 Assert.Equal("TestChild.Out", File.ReadAllText(outFile));
@@ -306,7 +306,7 @@ public void RedirectionToFile()
                 using (var sut = ChildProcess.Start(si))
                 {
                     sut.WaitForExit();
-                    Assert.True(sut.IsSuccessful);
+                    Assert.Equal(0, sut.ExitCode);
                 }
 
                 Assert.Equal("TestChild.OutTestChild.Error", File.ReadAllText(outFile));
@@ -329,7 +329,7 @@ public void RedirectionToFile()
                 using (var sut = ChildProcess.Start(si))
                 {
                     sut.WaitForExit();
-                    Assert.True(sut.IsSuccessful);
+                    Assert.Equal(0, sut.ExitCode);
                 }
 
                 Assert.Equal(text, File.ReadAllText(outFile));
@@ -356,7 +356,7 @@ public void CanRedirectToSameFile()
                 using (var sut = ChildProcess.Start(si))
                 {
                     sut.WaitForExit();
-                    Assert.True(sut.IsSuccessful);
+                    Assert.Equal(0, sut.ExitCode);
                 }
 
                 Assert.Equal("TestChild.OutTestChild.Error", File.ReadAllText(outFile));
@@ -373,7 +373,7 @@ public void CanRedirectToSameFile()
                 using (var sut = ChildProcess.Start(si))
                 {
                     sut.WaitForExit();
-                    Assert.True(sut.IsSuccessful);
+                    Assert.Equal(0, sut.ExitCode);
                 }
 
                 Assert.Equal("TestChild.OutTestChild.ErrorTestChild.OutTestChild.Error", File.ReadAllText(outFile));
@@ -404,7 +404,7 @@ public void RedirectionToHandle()
 
                     using var sut = ChildProcess.Start(si);
                     sut.WaitForExit();
-                    Assert.True(sut.IsSuccessful);
+                    Assert.Equal(0, sut.ExitCode);
                 }
 
                 Assert.Equal("TestChild.Out", File.ReadAllText(outFile));
@@ -428,7 +428,7 @@ public void RedirectionToHandle()
 
                     using var sut = ChildProcess.Start(si);
                     sut.WaitForExit();
-                    Assert.True(sut.IsSuccessful);
+                    Assert.Equal(0, sut.ExitCode);
                 }
 
                 Assert.Equal(text, File.ReadAllText(outFile));

src/ChildProcess.Test/ProcessManagement/ChildProcessTest_Waiting.cs

@@ -24,7 +24,6 @@ public void CanObtainExitCode()
 
                 using var sut = ChildProcess.Start(si);
                 sut.WaitForExit();
-                Assert.True(sut.IsSuccessful);
                 Assert.Equal(0, sut.ExitCode);
             }
 
@@ -40,7 +39,7 @@ public void CanObtainExitCode()
 
                 using var sut = ChildProcess.Start(si);
                 sut.WaitForExit();
-                Assert.False(sut.IsSuccessful);
+                Assert.NotEqual(0, sut.ExitCode);
                 Assert.Equal(nonZeroExitCode, sut.ExitCode);
             }
         }
@@ -54,13 +53,11 @@ public void ExitCodeThrowsBeforeChildExits()
             };
 
             using var sut = ChildProcess.Start(si);
-            Assert.Throws<InvalidOperationException>(() => sut.IsSuccessful);
             Assert.Throws<InvalidOperationException>(() => sut.ExitCode);
 
             sut.StandardInput.Close();
             sut.WaitForExit();
 
-            Assert.True(sut.IsSuccessful);
             Assert.Equal(0, sut.ExitCode);
         }
 

src/ChildProcess/ProcessManagement/ChildProcessImpl.cs

@@ -50,7 +50,6 @@ public void Dispose()
             }
         }
 
-        public bool IsSuccessful => ExitCode == 0;
         public bool HasStandardInput => _standardInput is not null;
         public bool HasStandardOutput => _standardOutput is not null;
         public bool HasStandardError => _standardError is not null;

src/ChildProcess/ProcessManagement/IChildProcess.cs

@@ -34,12 +34,6 @@ public interface IChildProcess : IDisposable
         /// </remarks>
         int Id { get; }
 
-        /// <summary>
-        /// Gets a value indicating whether the exit code of the process is 0.
-        /// </summary>
-        /// <exception cref="InvalidOperationException">The process has not exited yet.</exception>
-        bool IsSuccessful { get; }
-
         /// <summary>
         /// <para>Gets the exit code of the process.</para>
         /// <para>(Non-Windows-Specific) If the process was terminated by signal N, the exit code will be -N.</para>