chore: upgrade to go 1.26, rules_go 0.60 by jbedard · Pull Request #110 · aspect-build/aspect-gazelle

jbedard · 2025-10-24T21:25:13Z

Changes are visible to end-users: no

Test plan

Covered by existing test cases

Copilot

Pull Request Overview

This PR upgrades the project from Go 1.24.5 to Go 1.25.3 and updates rules_go from version 0.56.1 to 0.57.0. The upgrade includes adopting new Go 1.25 standard library features such as strings.CutSuffix, strings.SplitSeq, and slices.Grow to replace older patterns.

Key Changes

Updated Go version to 1.25.3 across all go.mod files and go.work
Updated rules_go dependency to 0.57.0 in all MODULE.bazel files
Refactored code to use Go 1.25 standard library features for improved performance and readability
Removed darwin-aarch64 LLVM toolchain configuration

Reviewed Changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
runner/pkg/git/gitignore_test.go	Replaced `HasSuffix`/`TrimSuffix` pattern with `strings.CutSuffix` and adopted `strings.SplitSeq`
runner/llvm.MODULE.bazel	Removed darwin-aarch64 LLVM toolchain configuration entries
runner/go.mod	Updated Go version from 1.24.5 to 1.25.3
runner/MODULE.bazel	Updated rules_go version from 0.56.1 to 0.57.0
language/orion/go.mod	Updated Go version from 1.24.5 to 1.25.3
language/orion/MODULE.bazel	Updated rules_go version from 0.56.1 to 0.57.0
language/kotlin/go.mod	Updated Go version from 1.24.5 to 1.25.3
language/kotlin/MODULE.bazel	Updated rules_go version from 0.56.1 to 0.57.0
language/js/typescript/tsconfig.go	Added `slices.Grow` for pre-allocation optimization
language/js/node/std_modules.go	Replaced `strings.Split` with `strings.SplitSeq`
language/js/go.mod	Updated Go version from 1.24.5 to 1.25.3
language/js/configure.go	Replaced `strings.Index` pattern with `strings.Cut` and adopted `strings.SplitSeq`
language/js/MODULE.bazel	Updated rules_go version from 0.56.1 to 0.57.0
go.work	Updated Go version from 1.25.0 to 1.25.3
common/go.mod	Updated Go version from 1.24.5 to 1.25.3
MODULE.bazel	Updated rules_go version from 0.56.1 to 0.57.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

aspect-workflows · 2025-10-24T21:40:42Z

Test

All tests were cache hits

4 tests (100.0%) were fully cached saving 248ms.

Test

language/js

All tests were cache hits

124 tests (100.0%) were fully cached saving 20s.

Test

language/kotlin

All tests were cache hits

19 tests (100.0%) were fully cached saving 4s.

Test

language/orion

All tests were cache hits

52 tests (100.0%) were fully cached saving 7s.

Test

runner

All tests were cache hits

30 tests (100.0%) were fully cached saving 5s.

Test

runner/e2e/bin

All tests were cache hits

1 test (100.0%) was fully cached saving 93ms.

Buildifier Gazelle Gazelle [language/js] Gazelle [language/kotlin] Gazelle [language/orion] Gazelle [runner] Gazelle [runner/e2e/bin]

Copilot

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CLAassistant · 2026-01-23T02:36:55Z

All committers have signed the CLA.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

language/js/MODULE.bazel

language/kotlin/MODULE.bazel

language/orion/MODULE.bazel

Copilot · 2026-02-14T02:54:43Z

MODULE.bazel

 )

-bazel_dep(name = "rules_go", version = "0.59.0")
+bazel_dep(name = "rules_go", version = "0.60.0")


The PR title says this upgrades rules_go to 0.57, but this change sets rules_go to 0.60.0. Please align the PR title/description with the actual version being upgraded to (or adjust the version here if 0.57 was intended).

MODULE.bazel

runner/MODULE.bazel

go.work.sum

go.work

jbedard · 2026-03-13T03:59:16Z

@codex

Copilot

Pull request overview

Copilot reviewed 12 out of 17 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chatgpt-codex-connector · 2026-03-13T04:04:26Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Copilot reviewed 12 out of 17 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jbedard · 2026-03-13T04:19:23Z

@codex

Copilot

Pull request overview

Copilot reviewed 12 out of 17 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

go.work

Copilot AI review requested due to automatic review settings October 24, 2025 21:25

Copilot AI reviewed Oct 24, 2025

View reviewed changes

jbedard force-pushed the go-125 branch from 90155fb to c9c01cc Compare October 24, 2025 21:40

jbedard requested a review from Copilot October 30, 2025 15:45

jbedard force-pushed the go-125 branch from c9c01cc to 8fc6015 Compare October 30, 2025 15:46

Copilot AI reviewed Oct 30, 2025

View reviewed changes

jbedard force-pushed the go-125 branch from 8fc6015 to ac31585 Compare November 14, 2025 23:40

jbedard force-pushed the go-125 branch from ac31585 to d5f0fa4 Compare February 14, 2026 02:49

Copilot AI review requested due to automatic review settings February 14, 2026 02:49

Copilot started reviewing on behalf of jbedard February 14, 2026 02:49 View session

Copilot AI reviewed Feb 14, 2026

View reviewed changes

jbedard force-pushed the go-125 branch from d5f0fa4 to e97bed7 Compare March 13, 2026 03:55

Copilot AI review requested due to automatic review settings March 13, 2026 03:59

jbedard force-pushed the go-125 branch from e97bed7 to 20d75d7 Compare March 13, 2026 03:59

Copilot started reviewing on behalf of jbedard March 13, 2026 03:59 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

jbedard changed the title ~~chore: upgrade to go 1.25, rules_go 0.57~~ chore: upgrade to go 1.26, rules_go 0.60 Mar 13, 2026

jbedard force-pushed the go-125 branch 2 times, most recently from ab6f026 to 2151fde Compare March 13, 2026 04:08

Copilot AI review requested due to automatic review settings March 13, 2026 04:08

Copilot started reviewing on behalf of jbedard March 13, 2026 04:08 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

jbedard force-pushed the go-125 branch from 2151fde to fd43bec Compare March 13, 2026 04:18

jbedard requested a review from Copilot March 13, 2026 04:19

Copilot started reviewing on behalf of jbedard March 13, 2026 04:19 View session

jbedard marked this pull request as ready for review March 13, 2026 04:19

Copilot AI reviewed Mar 13, 2026

View reviewed changes

go.work Show resolved Hide resolved

chore: upgrade to go 1.25, rules_go 0.60.0

5f8d55a

jbedard force-pushed the go-125 branch from fd43bec to 5f8d55a Compare March 13, 2026 04:25

jbedard merged commit d41786e into main Mar 13, 2026
2 of 3 checks passed

jbedard deleted the go-125 branch March 13, 2026 04:25

Uh oh!

Conversation

jbedard commented Oct 24, 2025

Changes are visible to end-users: no

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

aspect-workflows bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test

Test

language/js

Test

language/kotlin

Test

language/orion

Test

runner

Test

runner/e2e/bin

Buildifier Gazelle Gazelle [language/js] Gazelle [language/kotlin] Gazelle [language/orion] Gazelle [runner] Gazelle [runner/e2e/bin]

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

CLAassistant commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbedard commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

chatgpt-codex-connector bot commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

jbedard commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aspect-workflows bot commented Oct 24, 2025 •

edited

Loading

CLAassistant commented Jan 23, 2026 •

edited

Loading