Skip to content

Add a file that matches the glob in the exports#207

Draft
MatrixFrog wants to merge 1 commit intoaspect-build:mainfrom
MatrixFrog:export-stars
Draft

Add a file that matches the glob in the exports#207
MatrixFrog wants to merge 1 commit intoaspect-build:mainfrom
MatrixFrog:export-stars

Conversation

@MatrixFrog
Copy link

@MatrixFrog MatrixFrog commented Mar 5, 2026

@aspect-workflows
Copy link

aspect-workflows bot commented Mar 5, 2026

Test

All tests were cache hits

4 tests (100.0%) were fully cached saving 321ms.


Test

language/js

⚠️ Buildkite build #709 failed.

Failed tests (1)
//tests:npm_package_deps_lib_test [k8-fastbuild]🔗

💡 To reproduce the test failures, run

bazel test //tests:npm_package_deps_lib_test

Test

language/kotlin

All tests were cache hits

19 tests (100.0%) were fully cached saving 5s.


Test

language/orion

All tests were cache hits

51 tests (100.0%) were fully cached saving 9s.


Test

runner

All tests were cache hits

30 tests (100.0%) were fully cached saving 7s.


Test

runner/e2e/bin

All tests were cache hits

1 test (100.0%) was fully cached saving 93ms.


Buildifier      Gazelle      Gazelle [language/js]      Gazelle [language/kotlin]      Gazelle [language/orion]      Gazelle [runner]      Gazelle [runner/e2e/bin]

"//exports-js/bin:tsc",
"//exports-js/lib:tsc",
"//exports-js/lib2:tsc",
"//exports-js/stars:tsc",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test fails because Gazelle does not add this line. Am I correct in thinking that it should?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned on slack... I think that is too generic, that means it will match every file in that directory such as foo.spec.js and then your package will suddenly be bundling tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants