chore: remove go.mod replace directives for common and language modules, relying on go.work for local dev#209
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes intra-repo replace directives from the Go modules so local development relies on the repository’s go.work workspace, and updates the resulting module requirements/sums accordingly.
Changes:
- Removed
replacedirectives pointing at../commonand../language/*from modulego.modfiles. - Updated
github.com/aspect-build/aspect-gazelle/commonpseudo-version requirements and refreshedgo.sumfiles after dependency resolution. - Updated
go.work.sumto reflect the workspace’s dependency graph changes.
Reviewed changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| runner/go.mod | Drops local replace directives; updates common version and indirect deps. |
| runner/go.sum | Updates sums after removing replaces and re-resolving deps. |
| language/js/go.mod | Drops common replace; pins common to a pseudo-version. |
| language/js/go.sum | Adds sums for the updated common version. |
| language/kotlin/go.mod | Drops common replace; replaces zero version with a pseudo-version for common. |
| language/kotlin/go.sum | Adds sums for the updated common version. |
| language/orion/go.mod | Drops common replace; pins common to a pseudo-version. |
| language/orion/go.sum | Adds sums for the updated common version. |
| go.work.sum | Workspace sum adjustments after module graph changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
There was a problem hiding this comment.
Pull request overview
This PR removes intra-repo replace directives from Go modules so local development relies on the repository go.work workspace, while pinning internal module dependencies via pseudo-versions for non-workspace builds.
Changes:
- Removed
replacedirectives inrunner/andlanguage/*modules forcommonand language modules. - Updated required pseudo-versions for internal modules to
v0.0.0-20260306195717-555bd7327593. - Updated
go.sum/go.work.sumentries to reflect dependency graph changes.
Reviewed changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| runner/go.mod | Drops local replace directives; bumps internal module pseudo-versions; updates indirect deps. |
| runner/go.sum | Updates checksums for dependency changes (but currently inconsistent for language module versions). |
| language/orion/go.mod | Removes replace for common; pins common to a pseudo-version. |
| language/orion/go.sum | Adds checksums for the pinned common version. |
| language/kotlin/go.mod | Removes replace for common; replaces placeholder version with a real pseudo-version. |
| language/kotlin/go.sum | Adds checksums for the pinned common version. |
| language/js/go.mod | Removes replace for common; pins common to a pseudo-version. |
| language/js/go.sum | Adds checksums for the pinned common version. |
| go.work.sum | Updates workspace-level sums (but includes seemingly stale internal-module go.mod sums). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…es, relying on go.work for local dev
There was a problem hiding this comment.
Pull request overview
This PR removes intra-repo replace directives from Go modules so local development relies on the top-level go.work workspace, while keeping module dependencies resolvable via pinned pseudo-versions.
Changes:
- Removed
replacedirectives inrunnerandlanguage/*Go modules and updated internal module requirements to a consistent pseudo-version. - Updated corresponding
go.sumfiles to reflect the new resolved module versions/checksums. - Adjusted
runner/MODULE.bazeluse_repo(...)list forgo_deps.
Reviewed changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| runner/go.mod | Drops local replace directives; pins internal modules to a new pseudo-version. |
| runner/go.sum | Adds sums for internal modules now resolved by version rather than replace. |
| runner/MODULE.bazel | Updates go_deps use_repo(...) list. |
| language/js/go.mod | Drops replace; updates common requirement to new pseudo-version. |
| language/js/go.sum | Adds sums for common at the new pseudo-version. |
| language/kotlin/go.mod | Drops replace; replaces placeholder common version with new pseudo-version. |
| language/kotlin/go.sum | Adds sums for common at the new pseudo-version. |
| language/orion/go.mod | Drops replace; updates common requirement to new pseudo-version. |
| language/orion/go.sum | Adds sums for common at the new pseudo-version. |
| go.work.sum | Updates workspace sums due to the module graph changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Removes local replace directives from the Go submodules so local development relies on the repository go.work workspace, while ensuring the modules still resolve correctly when used outside the workspace.
Changes:
- Removed
replacedirectives inrunnerandlanguage/*Go modules that pointed to local paths. - Updated
requiredirectives to reference the corresponding published/pseudo-versions of sibling modules. - Regenerated
go.sum/go.work.sumentries to match the updated module graph.
Reviewed changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| runner/go.mod | Drops local replaces; pins common + language modules to a specific pseudo-version. |
| runner/go.sum | Adds checksums for the sibling modules now fetched via require when not using go.work. |
| language/js/go.mod | Drops local replace; pins common to a specific pseudo-version. |
| language/js/go.sum | Adds checksums for common at the pinned version. |
| language/kotlin/go.mod | Drops local replace; replaces placeholder common version with a real pseudo-version. |
| language/kotlin/go.sum | Adds checksums for common at the pinned version. |
| language/orion/go.mod | Drops local replace; pins common to a specific pseudo-version. |
| language/orion/go.sum | Adds checksums for common at the pinned version. |
| go.work.sum | Updates workspace sum file to reflect the refreshed dependency graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |


Changes are visible to end-users: no
Test plan