Skip to content

Some questionable TypeScript code changes #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Some questionable TypeScript code changes #343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b3fd17
Some questionable TypeScript code changes
alexeagle Aug 28, 2024
0d71880
Update logger/frontend/index.ts
alexeagle Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion logger/frontend/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@
}

private displayServerLogs(data: Response) {
console.log('in display');
const logMessage = 'in display';
try {

Check failure on line 44 in logger/frontend/index.ts

View check run for this annotation

Aspect Workflows / Lint

ESLint found an issue 

Unnecessary try/catch wrapper. (no-useless-catch)
console.log(logMessage);
} catch (e) {
throw e;
}

const el: HTMLElement = document.getElementById('log_results')!;
el.innerHTML = '';
Expand Down
Loading