Skip to content

Conversation

@sallustfire
Copy link

Allows esbuild config attribute to accept a js_library target, automatically including its dependencies (e.g., esbuild plugins) in the build without manually adding them to srcs.

This fixes the issue where config files with dependencies required users to manually specify those dependencies in the esbuild rule's srcs attribute.

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: no
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

config files have their transitive dependencies propagated to esbuild

Test plan

  • Covered by existing test cases which were extended

Allows esbuild config attribute to accept a js_library target,
automatically including its dependencies (e.g., esbuild plugins)
in the build without manually adding them to srcs.

This fixes the issue where config files with dependencies required
users to manually specify those dependencies in the esbuild rule's
srcs attribute.
@aspect-workflows
Copy link

aspect-workflows bot commented Nov 8, 2025

Test (Bazel 7) (Test)

All tests were cache hits

18 tests (100.0%) were fully cached saving 1s.


Test (Bazel 8) (Test)

All tests were cache hits

18 tests (100.0%) were fully cached saving 849ms.


Test (Bazel 7) (Test)

e2e/bundle

All tests were cache hits

2 tests (100.0%) were fully cached saving 96ms.


Test (Bazel 8) (Test)

e2e/bundle

All tests were cache hits

2 tests (100.0%) were fully cached saving 110ms.


Test (Bazel 7) (Test)

e2e/custom_version

All tests were cache hits

2 tests (100.0%) were fully cached saving 156ms.


Test (Bazel 8) (Test)

e2e/custom_version

All tests were cache hits

2 tests (100.0%) were fully cached saving 161ms.


Test (Bazel 7) (Test)

e2e/npm-links

All tests were cache hits

2 tests (100.0%) were fully cached saving 107ms.


Test (Bazel 8) (Test)

e2e/npm-links

All tests were cache hits

2 tests (100.0%) were fully cached saving 94ms.


Test (Bazel 7) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test (Bazel 8) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.


Test (Bazel 7) (Test)

e2e/sourcemaps

All tests were cache hits

7 tests (100.0%) were fully cached saving 313ms.


Test (Bazel 8) (Test)

e2e/sourcemaps

All tests were cache hits

7 tests (100.0%) were fully cached saving 335ms.


Test (Bazel 7) (Test)

e2e/toolchain_from_source

All tests were cache hits


Test (Bazel 8) (Test)

e2e/toolchain_from_source

All tests were cache hits


Test (Bazel 7) (Test)

e2e/tsconfig

All tests were cache hits

3 tests (100.0%) were fully cached saving 135ms.


Test (Bazel 8) (Test)

e2e/tsconfig

All tests were cache hits

3 tests (100.0%) were fully cached saving 165ms.


Buildifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant