Skip to content

Commit ec41261

Browse files
committed
refactor: remove js_image_layer(generate_empty_layers)
1 parent 7e0bb66 commit ec41261

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

docs/js_image_layer.md

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/private/js_image_layer.bzl

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -437,9 +437,6 @@ def _repo_mapping_manifest(files_to_run):
437437
_ENTRY = '"%s":{"dest":%s,"root":"%s","is_external":%s,"is_source":%s,"repo_name":"%s"},\n%s:"%s"'
438438

439439
def _js_image_layer_impl(ctx):
440-
if ctx.attr.generate_empty_layers:
441-
# buildifier: disable=print
442-
print("The `generate_empty_layers` attribute is deprecated and will be removed in the next major release. Its behavior is now implicitly `True`")
443440
if len(ctx.attr.binary) != 1:
444441
fail("binary attribute has more than one transition")
445442

@@ -656,11 +653,6 @@ js_image_layer_lib = struct(
656653
"platform": attr.label(
657654
doc = "Platform to transition.",
658655
),
659-
"generate_empty_layers": attr.bool(
660-
# TODO(3.0): remove this attribute.
661-
doc = """DEPRECATED. An empty layer is always generated if the layer group have no matching files.""",
662-
default = False,
663-
),
664656
"preserve_symlinks": attr.string(
665657
doc = """Preserve symlinks for entries matching the pattern.
666658
By default symlinks within the `node_modules` is preserved.

0 commit comments

Comments
 (0)