Skip to content

refactor: ensure fs patch tests are run on real fs library #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

refactor: ensure fs patch tests are run on real fs library #2378

merged 1 commit into from
Oct 7, 2025

Conversation

@jbedard
Copy link
Member

@jbedard jbedard commented Oct 4, 2025 •
edited
Loading

To move toward the refactoring in #2366 where this seems required.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@jbedard jbedard requested review from alexeagle and removed request for alexeagle October 4, 2025 02:10
@jbedard jbedard marked this pull request as draft October 4, 2025 02:10
@aspect-workflows
Copy link

aspect-workflows bot commented Oct 4, 2025 •
edited
Loading

Test

6 test targets passed

Targets 
//js/private/test/image/non_ascii:assert_custom_layer_groups_test_just_the_fs_patch_test [k8-fastbuild] 99ms
//js/private/test/image:assert_custom_layers_nomatch_test_node_test [k8-fastbuild]                      63ms
//js/private/test/image:assert_custom_owner_test_node_test [k8-fastbuild]                               104ms
//js/private/test/image:assert_default_test_node_test [k8-fastbuild]                                    92ms
//js/private/test/image:assert_regex_edge_cases_test_node_test [k8-fastbuild]                           65ms
//js/private/test/image:checksum_test_test_test [k8-fastbuild]                                          65ms

Total test execution time was 488ms. 247 tests (97.6%) were fully cached saving 38s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 704ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 216ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 563ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 411ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 381ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 78ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 329ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

67 tests (100.0%) were fully cached saving 9s.

Test

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 4s.

Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 411ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 270ms.

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 105ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 110ms.

Buildifier      Format

@jbedard jbedard force-pushed the esm-escaping-pre-0 branch 3 times, most recently from 95c15b9 to c6d1919 Compare October 4, 2025 02:15
jbedard
jbedard commented Oct 4, 2025
View reviewed changes
@jbedard jbedard marked this pull request as ready for review October 4, 2025 18:58
@jbedard jbedard requested a review from dzbarsky October 6, 2025 20:12
@jbedard jbedard force-pushed the esm-escaping-pre-0 branch from c6d1919 to 988f79e Compare October 6, 2025 22:06
@jbedard jbedard mentioned this pull request Oct 7, 2025
Merged
@jbedard jbedard force-pushed the esm-escaping-pre-0 branch from 988f79e to e4ebf4c Compare October 7, 2025 17:08
dzbarsky
dzbarsky approved these changes Oct 7, 2025
View reviewed changes
@jbedard jbedard force-pushed the esm-escaping-pre-0 branch 3 times, most recently from b56caaf to d68828e Compare October 7, 2025 18:15
@jbedard jbedard force-pushed the esm-escaping-pre-0 branch from d68828e to 5662414 Compare October 7, 2025 18:24
@jbedard jbedard enabled auto-merge (rebase) October 7, 2025 18:30
@jbedard jbedard merged commit 2716fea into aspect-build:main Oct 7, 2025
99 checks passed
@jbedard jbedard deleted the esm-escaping-pre-0 branch October 7, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzbarsky dzbarsky dzbarsky approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbedard @dzbarsky