Skip to content

Conversation

@jbedard
Copy link
Member

@jbedard jbedard commented Oct 7, 2025

Converting the source files to mjs, then testing on both mjs and babel-transpiled cjs.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@aspect-workflows
Copy link

aspect-workflows bot commented Oct 7, 2025

Test

1 test target passed

Targets
//npm/private/test:write_npm_translate_lock_0_test [k8-fastbuild] 123ms

Total test execution time was 123ms. 277 tests (99.6%) were fully cached saving 48s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 642ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 208ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 510ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 754ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 398ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 119ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 315ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

67 tests (100.0%) were fully cached saving 9s.


Test

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 4s.


Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 436ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 264ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 201ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 141ms.


Buildifier      Format

@jbedard jbedard force-pushed the esm-patch-testing branch 4 times, most recently from 6cf39bb to d908df6 Compare October 7, 2025 18:37
@jbedard jbedard enabled auto-merge (rebase) October 7, 2025 18:37
@jbedard jbedard force-pushed the esm-patch-testing branch from d908df6 to f8820ee Compare October 7, 2025 19:02
@jbedard jbedard merged commit 57fee21 into aspect-build:main Oct 7, 2025
99 checks passed
@jbedard jbedard deleted the esm-patch-testing branch October 7, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants