Skip to content

Commit de35052

Browse files
Matt Mackayalexeagle
andauthored
fix: allow symlink collision error to be downgraded (#369)
Introduces an attr allowing the symlink collision errors to be downgraded to a warning or ignored. Closes #358 --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): yes - Suggested release notes appear below: Allow the "conflicting symlinks" error when creating a venv to be downgraded to a warning and ignored. ### Test plan - Manual testing; please provide instructions so we can reproduce: Run `//py/tests/virtual/django:manage` with the `pyqt6` packages installed. --------- Co-authored-by: Alex Eagle <[email protected]>
1 parent 9730638 commit de35052

File tree

24 files changed

+442
-17037
lines changed

24 files changed

+442
-17037
lines changed

.github/workflows/ci.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,10 @@ jobs:
4141
- uses: actions/checkout@v4
4242
- run: patch --dry-run -p1 < .bcr/patches/*.patch
4343

44-
test-release:
45-
runs-on: ubuntu-latest
46-
steps:
47-
- uses: actions/checkout@v4
48-
- working-directory: e2e/use_release
49-
run: ./minimal_download_test.sh
44+
# TODO(alex): enable after next release. Matt will yell at you if you forget.
45+
# test-release:
46+
# runs-on: ubuntu-latest
47+
# steps:
48+
# - uses: actions/checkout@v4
49+
# - working-directory: e2e/use_release
50+
# run: ./minimal_download_test.sh

0 commit comments

Comments
 (0)