fix: re-establish pre-3.2.1 copy_data_to_bin behavior

[gzm0]

Fixes #716 (and breaks #411 again).

---

Changes are visible to end-users: yes/no

• Searched for relevant documentation and updated as needed: yes
• Breaking change (forces users to change their own code or config): no (re-establishes backwards compatible behavior).
• Suggested release notes appear below: no

Test plan

• New test cases added

I have manually checked that the new tests:

• Pass at 3.2.0
• Fail at 3.2.1

[aspect-workflows]

Test

All tests were cache hits

144 tests (100.0%) were fully cached saving 10s.

---

Buildifier      Format

[gzm0]

Ready for review.

An alternative would be to not include the additional parameter in the macro.

[jbedard]

Hey @gzm0, sorry I forgot about this PR and did 41a2678 which I think solves both issues? Can you check it out plz 🙏

[gzm0]

Sorry for the delayed reply, I was on vacation. I've answered here: #723 (comment)

[alexeagle]

@jbedard I believe the answer is yes, the bug still exists at HEAD.
Since this PR includes a repro, it hopefully takes only a few minutes to rebase it and observe the problem again.

[gzm0]

Hum... The original issue was about misaligned behavior for copy_data_to_bin if transpiler is set or not. IIUC: #723 aligned the behavior, which was a breaking change, but (IMHO) the better overall behavior.

So at this point, with the change almost over a year old, I'm not sure it's a good idea to revert to the behavior that is technically correct under semver. I would suggest to:

• close this PR
• close [Bug]: copy_data_files_to_bin (for gather_runfiles) depends on whether transpiler is set #411 as fixed (probably verify before you take my word)
• close [Bug]: #710 changed copy_runfiles_to_bin behavior of ts_project if transpiler is set #716 as wontfix (probably verify before you take my word).

[jbedard]

That sounds best to me since no one else commented on this change in behaviour over the last year 👍