Skip to content

Conversation

@arrdem
Copy link
Collaborator

@arrdem arrdem commented Nov 26, 2025

By watching the lockfile we create a dependency cycle between the fingerprint of the lockfile and the fingerprint of the configuration of this extension. We don't want this extension to be reproducible, so just not watching the lockfile is the right way to handle this.

Fixes #20

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Fixed an issue which broke bazel mod deps --lockfile_mode=error.

Test plan

  • Manual testing; please provide instructions so we can reproduce:
$ cd examples/simple
$ bazel mod deps --lockfile_mode=error
Starting local Bazel server (8.4.2) and connecting to it...
ERROR: MODULE.bazel.lock is no longer up-to-date because: The implementation of the extension '@@aspect_tools_telemetry+//:extension.bzl%telemetry' or one of its transitive .bzl files has changed. Please run `bazel mod deps --lockfile_mode=update` to update your lockfile.
ERROR: The module extension '@@rules_python+//python/private/pypi:pip.bzl%pip_internal' does not exist in the lockfile
ERROR: The module extension '@@rules_fuzzing+//fuzzing/private:extensions.bzl%non_module_dependencies' does not exist in the lockfile
ERROR: The module extension '@@rules_kotlin+//src/main/starlark/core/repositories:bzlmod_setup.bzl%rules_kotlin_extensions' does not exist in the lockfile
ERROR: The module extension '@@pybind11_bazel+//:python_configure.bzl%extension' does not exist in the lockfile
<root> ([email protected])

ERROR: Results may be incomplete as 5 extensions failed.

$ bazel mod deps --lockfile_mode=update
<root> ([email protected])

$ bazel mod deps --lockfile_mode=error
<root> ([email protected])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: tools_telemetry 0.3.0 is unstable under bazel mod deps

2 participants