Partially implement core/version-check endpoint.#252
Partially implement core/version-check endpoint.#252costdev wants to merge 8 commits intoaspirepress:mainfrom
core/version-check endpoint.#252Conversation
| $translation->slug = 'default'; | ||
| $translation->language = $this->locale; | ||
| $translation->version = $this->currentVersion; | ||
| $translation->updated = '2023-10-01T00:00:00Z'; // Store in DB from the translations file. Pull from DB for here. |
There was a problem hiding this comment.
This data should be compared with the request body's subkey containing the currently installed translation's data including its updated time string. If the updated value is the same as the API's latest translation for that type/slug/version/locale, then no translation is needed. Otherwise, the API should provide the translation offer. If the value isn't set, or there's no body, or otherwise isn't available, the API should provide the translation offer.
|
This will require some extensive modification to fit AC's architecture, and we would definitely want to support rollback, since I don't think mixing backends between AC and .org during a single extended "transaction" would be ideal. I'd like to see some captures of a rollback happening with .org and replay them on AC to ensure we can replicate the resulting state. |
chuckadams
left a comment
There was a problem hiding this comment.
I'm calling this a work in progress and marking the PR as draft. It has valuable information on things like the query format, so I don't want to see it all drift away if this PR were closed, but it's being put on one of our many back burners.
Pull Request
What changed?
This introduces a partial controller implementation for
core/version-check.Notes:
partialandrollbackvalues aren't covered (yet, maybe?).config('app.aspirecloud.download.base'). I think that's correct.Did you fix any specific issues?
Related: #52
CERTIFICATION
By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.