Fix Alipay user_id upgrade open_id issue#1015
Fix Alipay user_id upgrade open_id issue#1015martincostello merged 1 commit intoaspnet-contrib:devfrom
Conversation
Could you please summarise this document into English as to what is being changed and why? Changes also need tests. |
Additionally, how can I add test cases? I have already applied the changes to my production environment. |
The existing tests for Alipay are here. You can see we stub out the responses, so you'd have to extend the tests to exercise these new changes. |
|
How do I modify |
|
I couldn't find a test for exceptional data. I also hope I can provide an elegant test |
|
The extended test of Alipay has been added |
src/AspNet.Security.OAuth.Alipay/AlipayAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Alipay/AlipayAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Alipay/AlipayAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Alipay/AlipayAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Alipay/AlipayTests.cs
Outdated
Show resolved
Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Alipay/AlipayTests.cs
Outdated
Show resolved
Hide resolved
9c46e50 to
50d53f2
Compare
|
Could you please review it again? @martincostello |
|
Thanks for your contribution - this change will go out when #1020 is completed. If you want to use it before then, then please consume the prerelease packages from our MyGet feed. |
|
Thanks again for your contribution - the changes are now available from NuGet.org in v9.1.0. |
Updated [AspNet.Security.OAuth.GitHub](git://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers) from 8.3.0 to 9.4.1. <details> <summary>Release notes</summary> _Sourced from [AspNet.Security.OAuth.GitHub's releases](git://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/releases)._ ## 9.4.1 ## What's Changed * Perf optimization for Bilibili provider by @LeaFrock in aspnet-contrib/AspNet.Security.OAuth.Providers#1071 * Bilibili refactor by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#1072 * Add CodeQL for GitHub Actions by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#1095 * Use NuGet Trusted Publishing by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#1110 * feat(Keycloak): add "family_name" mapping to ClaimTypes.Surname by @XB-RS in aspnet-contrib/AspNet.Security.OAuth.Providers#1112 ## New Contributors * @XB-RS made their first contribution in aspnet-contrib/AspNet.Security.OAuth.Providers#1112 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@9.4.0...9.4.1 ## 9.4.0 ## What's Changed * Add Bilibili provider by @Loongle in aspnet-contrib/AspNet.Security.OAuth.Providers#1044 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@9.3.0...9.4.0 ## 9.3.0 ## What's Changed * Add Contentful provider by @jerriep in aspnet-contrib/AspNet.Security.OAuth.Providers#1063 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@9.2.0...9.3.0 ## 9.2.0 ## What's Changed * Use `Convert.ToHexStringLower` by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#1048 * Add Linear provider by @jerriep in aspnet-contrib/AspNet.Security.OAuth.Providers#1045 * Add Miro provider by @jerriep in aspnet-contrib/AspNet.Security.OAuth.Providers#1046 * Add Webflow provider by @jerriep in aspnet-contrib/AspNet.Security.OAuth.Providers#1047 ## New Contributors * @jerriep made their first contribution in aspnet-contrib/AspNet.Security.OAuth.Providers#1045 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@9.1.0...9.2.0 ## 9.1.0 ## What's Changed * Allow roll-forward for dotnet-validate by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#989 * Update bundle data in KOOK provider test by @gehongyan in aspnet-contrib/AspNet.Security.OAuth.Providers#1021 * Fix Alipay user_id upgrade open_id issue by @Loongle in aspnet-contrib/AspNet.Security.OAuth.Providers#1015 * Add GitCode Provider by @gehongyan in aspnet-contrib/AspNet.Security.OAuth.Providers#1020 * Enable package validation by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#1031 * Add Atlassian provider #839 by @smnsht in aspnet-contrib/AspNet.Security.OAuth.Providers#1037 ## New Contributors * @Loongle made their first contribution in aspnet-contrib/AspNet.Security.OAuth.Providers#1015 * @smnsht made their first contribution in aspnet-contrib/AspNet.Security.OAuth.Providers#1037 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@9.0.0...9.1.0 ## 9.0.0 ## What's Changed * Update to .NET 9 by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#833 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@8.3.0...9.0.0 Commits viewable in [compare view](git://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/compare/8.3.0...9.4.1). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
References: https://opendocs.alipay.com/common/0ai2i6?pathHash=cba76ebf