Update to ASP.NET Core 11 preview 2#1177
Merged
martincostello merged 3 commits intodev-v11from Mar 10, 2026
Merged
Conversation
Update to preview 2 of ASP.NET Core 11.
Use `JsonElement.Parse()` instead of `JsonDocument.Parse().RootElement`.
martincostello
force-pushed
the
dotnet-11-preview.2
branch
from
58753a5 to
b9d103c
Compare
There was a problem hiding this comment.
Pull request overview
Updates the repository to ASP.NET Core 11 preview 2 by aligning the pinned .NET SDK/tooling and ASP.NET Core package versions, plus a small compatibility change in the Xero OAuth handler.
Changes:
- Bump pinned .NET SDK/tooling to
11.0.100-preview.2.26159.112(global.json). - Update ASP.NET Core package versions to
11.0.0-preview.2.26159.112and increment prerelease iteration to 2. - Adjust Xero handler ticket context creation to use
JsonElement.Parse("{}").
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/AspNet.Security.OAuth.Xero/XeroAuthenticationHandler.cs |
Updates JSON element creation used when raising CreatingTicket during Xero auth. |
global.json |
Pins repo SDK/tool version to .NET 11 preview 2. |
eng/Versions.props |
Increments prerelease iteration/branding to preview 2. |
Directory.Packages.props |
Updates ASP.NET Core package versions to preview 2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var principal = new ClaimsPrincipal(identity); | ||
|
|
||
| var context = new OAuthCreatingTicketContext(principal, properties, Context, Scheme, Options, Backchannel, tokens, JsonDocument.Parse("{}").RootElement); | ||
| var context = new OAuthCreatingTicketContext(principal, properties, Context, Scheme, Options, Backchannel, tokens, JsonElement.Parse("{}")); |
There was a problem hiding this comment.
JsonElement.Parse("{}") parses the same constant JSON on every authentication request. Consider caching a single static/readonly empty JsonElement (or another reusable empty JSON object) and reusing it here to avoid repeated parsing/allocation in this hot path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to preview 2 of ASP.NET Core 11.