Skip to content

Fix offload task intermittently not running in MSTest environment. #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kalbert312 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix offload task intermittently not running in MSTest environment. #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.Owin.Testing/OwinClientHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@ protected override async Task<HttpResponseMessage> SendAsync(
registration.Dispose();
state.Dispose();
}
});
}, CancellationToken.None, TaskCreationOptions.DenyChildAttach, TaskScheduler.Default);
Copy link
Copy Markdown
Member

@BrennanConroy BrennanConroy Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the Task.Factory call inside RequestState.CompleteResponse() also be updated to use TaskScheduler.Default?

Copy link
Copy Markdown
Author

@kalbert312 kalbert312 Mar 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the issue is specific to StartNew with async callbacks, but not certain.

Copy link
Copy Markdown
Author

@kalbert312 kalbert312 Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some test debug runs on the minimal repo example. Could not get the non-async delegate usage of StartNew to not run. 😕


return await state.ResponseTask;
return await state.ResponseTask.ConfigureAwait(false);
}

private class RequestState : IDisposable
Expand Down