Skip to content

Switch SqlDataReader.ReadAsync to SqlDataReader.Read in SqlSessionStateProviderAsync because of a known performance issue with reading large data asynchronously #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjamin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Switch SqlDataReader.ReadAsync to SqlDataReader.Read in SqlSessionStateProviderAsync because of a known performance issue with reading large data asynchronously #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/SqlSessionStateProviderAsync/SqlSessionStateRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,11 +492,13 @@ public async Task<SessionItem> GetSessionStateItemAsync(string id, bool exclusiv
{
using (var reader = await SqlSessionStateRepositoryUtil.SqlExecuteReaderWithRetryAsync(connection, cmd, CanRetryAsync))
{
if (await reader.ReadAsync())
// use the synchronous versions of Read and GetFieldValue because of performance issues with
// large data described here: https://github.com/dotnet/SqlClient/issues/593
if (reader.Read())
{
// Varbinary(max) should not be returned in an output parameter
// Read the returned dataset consisting of SessionItemLong if found
buf = await reader.GetFieldValueAsync<byte[]>(0);
buf = reader.GetFieldValue<byte[]>(0);
}
}

Expand Down