Merge pull request #741 from aspnet/dev/phil-allen-msft/spaceBarOnFilesChangesState

phil-allen-msft · web-flow · commit 2f667c80608a · 2024-04-29T11:09:27.000-07:00
Spacebar on the "Files" node should toggle state
diff --git a/src/LibraryManager.Vsix/UI/Controls/PackageContentsTreeView.xaml.cs b/src/LibraryManager.Vsix/UI/Controls/PackageContentsTreeView.xaml.cs
@@ -31,7 +31,15 @@ private void OnPreviewKeyUp(object sender, KeyEventArgs e)
 
                 if (packageItem != null)
                 {
-                    packageItem.IsChecked = !packageItem.IsChecked;
+                    if (packageItem.IsChecked.HasValue)
+                    {
+                        packageItem.IsChecked = !packageItem.IsChecked;
+                    }
+                    else
+                    {
+                        // if it is partially checked, clear all selections, just like clicking with the mouse
+                        packageItem.IsChecked = false;
+                    }
                     e.Handled = true;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,15 @@ private void OnPreviewKeyUp(object sender, KeyEventArgs e)`
`31`	`31`
`32`	`32`	`if (packageItem != null)`
`33`	`33`	`{`
`34`		`- packageItem.IsChecked = !packageItem.IsChecked;`
	`34`	`+ if (packageItem.IsChecked.HasValue)`
	`35`	`+ {`
	`36`	`+ packageItem.IsChecked = !packageItem.IsChecked;`
	`37`	`+ }`
	`38`	`+ else`
	`39`	`+ {`
	`40`	`+ // if it is partially checked, clear all selections, just like clicking with the mouse`
	`41`	`+ packageItem.IsChecked = false;`
	`42`	`+ }`
`35`	`43`	`e.Handled = true;`
`36`	`44`	`}`
`37`	`45`	`}`