Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ on: [ push, pull_request ]

jobs:
ci:
runs-on: ubuntu-latest
strategy:
matrix:
gradle-version: [ '7.6.4', '8.7', '8.12.1', 'current' ]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scordio if you'd like to setup the plugin to run against more versions of the generator, we could adjust this matrix to include versions of the new generator. Read a system property or gradle property here: https://github.com/assertj/assertj-generator-gradle-plugin/pull/208/files#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06R75

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds cool, thanks! I want to rework both the generator and the Maven plugin a bit. I'll get in touch once these are in better shape 🙂

os: [ 'ubuntu-latest', 'macos-latest', 'windows-latest' ]

runs-on: ${{ matrix.os }}
if: github.event_name == 'pull_request' || (github.event_name == 'push' && github.ref == 'refs/heads/main')

steps:
Expand All @@ -18,7 +23,8 @@ jobs:

- uses: gradle/actions/setup-gradle@v4
with:
gradle-version: '8.12.1'
gradle-version: 8.12.1

- run:
./gradlew check --continue
./gradlew check --continue -Dtest.gradle.version.override='${{ matrix.gradle-version }}'
shell: bash
2 changes: 2 additions & 0 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ tasks.test {
useJUnitPlatform()

jvmArgs("-Djunit.jupiter.extensions.autodetection.enabled=true")

systemProperty("test.gradle.version", gradle.gradleVersion)
}

sourceSets {
Expand Down
5 changes: 5 additions & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
org.gradle.configuration-cache=true
org.gradle.caching=true
org.gradle.parallel=true
org.gradle.daemon=true

org.gradle.jvmargs=-Xmx1024M

Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ package org.assertj.generator.gradle

import net.navatwo.gradle.testkit.junit5.GradleProject
import org.assertj.core.api.Assertions.assertThat
import org.assertj.generator.gradle.TestUtils.withCiGradle
import org.gradle.testkit.runner.GradleRunner
import org.junit.jupiter.api.Test
import java.io.File
Expand All @@ -39,7 +40,7 @@ internal class IncrementalBuild {
@GradleProject.Root root: File,
@GradleProject.Runner runner: GradleRunner,
) {
val buildRunner = runner.withArguments("-i", "-s", "build")
val buildRunner = runner.withCiGradle().withArguments("-i", "-s", "build")

val firstBuild = buildRunner.build()

Expand All @@ -61,7 +62,7 @@ internal class IncrementalBuild {
@GradleProject.Root root: File,
@GradleProject.Runner runner: GradleRunner,
) {
val buildRunner = runner.withArguments("-i", "-s", "build")
val buildRunner = runner.withCiGradle().withArguments("-i", "-s", "build")

val firstBuild = buildRunner.build()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ package org.assertj.generator.gradle

import net.navatwo.gradle.testkit.junit5.GradleProject
import org.assertj.core.api.Assertions.assertThat
import org.assertj.generator.gradle.TestUtils.withCiGradle
import org.gradle.testkit.runner.GradleRunner
import org.junit.jupiter.api.Test
import java.io.File
Expand All @@ -25,7 +26,7 @@ internal class KotlinSourcesBuild {
@GradleProject.Root root: File,
@GradleProject.Runner runner: GradleRunner,
) {
val result = runner.withArguments("-i", "-s", "test").build()
val result = runner.withCiGradle().withArguments("-i", "-s", "test").build()

assertThat(result.task(":generateAssertJ")).isSuccessful()
assertThat(result.task(":test")).isSuccessful()
Expand Down
5 changes: 3 additions & 2 deletions src/test/kotlin/org/assertj/generator/gradle/SimpleBuild.kt
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ package org.assertj.generator.gradle

import net.navatwo.gradle.testkit.junit5.GradleProject
import org.assertj.core.api.Assertions.assertThat
import org.assertj.generator.gradle.TestUtils.withCiGradle
import org.assertj.generator.gradle.TestUtils.writeBuildFile
import org.assertj.generator.gradle.TestUtils.writeDefaultBuildFile
import org.gradle.testkit.runner.GradleRunner
Expand All @@ -36,7 +37,7 @@ internal class SimpleBuild {
) {
root.buildFile.writeDefaultBuildFile()

val result = runner.withArguments("-i", "-s", "test").build()
val result = runner.withCiGradle().withArguments("-i", "-s", "test").build()

assertThat(result.task(":generateAssertJ")).isSuccessful()
assertThat(result.task(":test")).isSuccessful()
Expand All @@ -60,7 +61,7 @@ internal class SimpleBuild {
"""
)

val result = runner.withArguments("-i", "-s", "test").build()
val result = runner.withCiGradle().withArguments("-i", "-s", "test").build()

assertThat(result.task(":generateAssertJ")).isSuccessful()
assertThat(result.task(":test")).isSuccessful()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ package org.assertj.generator.gradle

import net.navatwo.gradle.testkit.junit5.GradleProject
import org.assertj.core.api.Assertions.assertThat
import org.assertj.generator.gradle.TestUtils.withCiGradle
import org.gradle.testkit.runner.GradleRunner
import org.junit.jupiter.api.Test
import java.io.File
Expand All @@ -33,7 +34,7 @@ internal class SkipPackageInfo {
@GradleProject.Root root: File,
@GradleProject.Runner runner: GradleRunner,
) {
val result = runner.withArguments("-i", "-s", "check").build()
val result = runner.withCiGradle().withArguments("-i", "-s", "check").build()

assertThat(result.task(":generateAssertJ")).isSuccessful()
assertThat(result.task(":test")).isSuccessful()
Expand Down
10 changes: 9 additions & 1 deletion src/test/kotlin/org/assertj/generator/gradle/TestUtils.kt
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
*/
package org.assertj.generator.gradle

import org.gradle.testkit.runner.GradleRunner
import org.intellij.lang.annotations.Language
import java.io.File

Expand Down Expand Up @@ -76,5 +77,12 @@ internal object TestUtils {
)
}

fun File.writeDefaultBuildKts(): Unit = this.writeBuildKts("")
fun GradleRunner.withCiGradle(): GradleRunner {
return withGradleVersion(
System.getProperty(
"test.gradle.version.override",
System.getProperty("test.gradle.version")
)
)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ package org.assertj.generator.gradle.parameter

import net.navatwo.gradle.testkit.junit5.GradleProject
import org.assertj.core.api.Assertions.assertThat
import org.assertj.generator.gradle.TestUtils.withCiGradle
import org.assertj.generator.gradle.isSuccessful
import org.assertj.generator.gradle.writeGroovy
import org.assertj.generator.gradle.writeJava
Expand Down Expand Up @@ -77,7 +78,7 @@ internal class ClassesFilter {

root.setupTestHelloWorld()

runner.runAndAssertBuild()
runner.withCiGradle().runAndAssertBuild()

assertThat(root.generatedBasePackagePath.resolve("hello")).exists()
assertThat(root.generatedBasePackagePath.resolve("other")).doesNotExist()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ package org.assertj.generator.gradle.parameter
import net.navatwo.gradle.testkit.junit5.GradleProject
import org.assertj.assertions.generator.AssertionsEntryPointType
import org.assertj.core.api.AssertionsForInterfaceTypes.assertThat
import org.assertj.generator.gradle.TestUtils.withCiGradle
import org.assertj.generator.gradle.TestUtils.writeBuildFile
import org.assertj.generator.gradle.isSuccessful
import org.assertj.generator.gradle.isUpToDate
Expand Down Expand Up @@ -55,7 +56,7 @@ internal class EntryPointGeneration {
"""
)

val result = runner.withArguments("-i", "-s", "test").build()
val result = runner.withCiGradle().withArguments("-i", "-s", "test").build()

assertThat(result.task(":generateAssertJ")).isSuccessful()
assertThat(result.task(":test")).isSuccessful()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ package org.assertj.generator.gradle.parameter

import net.navatwo.gradle.testkit.junit5.GradleProject
import org.assertj.core.api.AssertionsForInterfaceTypes.assertThat
import org.assertj.generator.gradle.TestUtils.withCiGradle
import org.assertj.generator.gradle.TestUtils.writeBuildFile
import org.assertj.generator.gradle.capitalized
import org.assertj.generator.gradle.isSuccessful
import org.gradle.configurationcache.extensions.capitalized
import org.gradle.testkit.runner.GradleRunner
import org.junit.jupiter.api.Test
import java.io.File
Expand Down Expand Up @@ -51,7 +51,10 @@ internal class OutputDirectoryParameter {
"""
)

val result = runner.withArguments("-i", "-s", "test").build()
val result = runner
.withCiGradle()
.withArguments("-i", "-s", "test")
.build()

assertThat(result.task(":generateAssertJ")).isSuccessful()
assertThat(result.task(":test")).isSuccessful()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ package org.assertj.generator.gradle.parameter

import net.navatwo.gradle.testkit.junit5.GradleProject
import org.assertj.core.api.Assertions.assertThat
import org.assertj.generator.gradle.TestUtils.withCiGradle
import org.assertj.generator.gradle.isSuccessful
import org.assertj.generator.gradle.writeGroovy
import org.assertj.generator.gradle.writeJava
Expand Down Expand Up @@ -347,7 +348,10 @@ import static org.assertj.core.api.Assertions.assertThat;
)

private fun GradleRunner.runAndAssertBuild() {
val result = withDebug(true).withArguments("-i", "-s", "test").build()
val result = withDebug(true)
.withCiGradle()
.withArguments("-i", "-s", "test")
.build()

assertThat(result.task(":generateAssertJ")).isSuccessful()
assertThat(result.task(":test")).isSuccessful()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ package org.assertj.generator.gradle.parameter

import net.navatwo.gradle.testkit.junit5.GradleProject
import org.assertj.core.api.AssertionsForInterfaceTypes.assertThat
import org.assertj.generator.gradle.TestUtils.withCiGradle
import org.assertj.generator.gradle.TestUtils.writeBuildFile
import org.assertj.generator.gradle.capitalized
import org.assertj.generator.gradle.isSuccessful
Expand Down Expand Up @@ -71,7 +72,7 @@ internal class SkipParameter {
"""
)

val result = runner.withArguments("-i", "-s", "test").build()
val result = runner.withCiGradle().withArguments("-i", "-s", "test").build()

assertThat(result.task(":generateAssertJ")).isSuccessful()
assertThat(result.task(":test")).isSuccessful()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ package org.assertj.generator.gradle.parameter

import net.navatwo.gradle.testkit.junit5.GradleProject
import org.assertj.core.api.AssertionsForInterfaceTypes.assertThat
import org.assertj.generator.gradle.TestUtils.withCiGradle
import org.assertj.generator.gradle.TestUtils.writeBuildFile
import org.assertj.generator.gradle.isSuccessful
import org.assertj.generator.gradle.isUpToDate
Expand Down Expand Up @@ -58,7 +59,7 @@ internal class TemplateChanges {
"""
)

val result = runner.withArguments("-i", "-s", "test").build()
val result = runner.withCiGradle().withArguments("-i", "-s", "test").build()

assertThat(result.task(":generateAssertJ")).isSuccessful()
assertThat(result.task(":test")).isSuccessful()
Expand Down Expand Up @@ -90,7 +91,7 @@ internal class TemplateChanges {
"""
)

val testRunner = runner.withArguments("-i", "-s", "test")
val testRunner = runner.withCiGradle().withArguments("-i", "-s", "test")

val result = testRunner.build()

Expand Down Expand Up @@ -124,7 +125,7 @@ internal class TemplateChanges {
"""
)

val testRunner = runner.withArguments("-i", "-s", "test")
val testRunner = runner.withCiGradle().withArguments("-i", "-s", "test")

val result = testRunner.build()

Expand Down Expand Up @@ -163,7 +164,7 @@ internal class TemplateChanges {
"""
)

val testRunner = runner.withArguments("-i", "-s", "test")
val testRunner = runner.withCiGradle().withArguments("-i", "-s", "test")

val result = testRunner.build()

Expand Down Expand Up @@ -221,7 +222,7 @@ internal class TemplateChanges {
"""
)

val testRunner = runner.withArguments("-i", "-s", "test")
val testRunner = runner.withCiGradle().withArguments("-i", "-s", "test")

val result = testRunner.build()

Expand Down Expand Up @@ -290,7 +291,7 @@ internal class TemplateChanges {
"""
)

val testRunner = runner.withArguments("-i", "-s", "test")
val testRunner = runner.withCiGradle().withArguments("-i", "-s", "test")

val result = testRunner.build()

Expand Down Expand Up @@ -334,7 +335,7 @@ internal class TemplateChanges {
"""
)

val result = runner.withArguments("-i", "-s", "generateAssertJ").buildAndFail()
val result = runner.withCiGradle().withArguments("-i", "-s", "generateAssertJ").buildAndFail()

assertThat(result.output).contains("wholeNumberAssertion")
}
Expand Down
Loading