feat: support hiding Astarte Dashboard sidebar via annotation#539
Draft
lucamarchiori wants to merge 16 commits intoastarte-platform:masterfrom
Draft
feat: support hiding Astarte Dashboard sidebar via annotation#539lucamarchiori wants to merge 16 commits intoastarte-platform:masterfrom
lucamarchiori wants to merge 16 commits intoastarte-platform:masterfrom
Conversation
Upgrade OPM to version to v1.55.0 in the Makefile See: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#upgrade-opm-version-to-v1550-in-the-makefile Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
See: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#add-a-devcontainer-for-go-based-operators Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
See: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#add-new-github-actions-for-go-based-operators Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
Properly support TLS certificates for webhooks and metrics server See: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#update-your-project-to-properly-support-tls-certificates-for-webhooks-and-metrics-server Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
See: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#update-your-project-to-properly-support-tls-for-prometheus-scraping Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
See: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#update-your-project-to-properly-support-ca-injection-for-crds-with-conversion-webhooks Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
Use `.Named("<Kind>")` in SetupWithManager for controller registration
See: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#use-namedkind-in-setupwithmanager-for-controller-registration
Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
The SDK now automates the setup of ENVTEST for Go-based operators by dynamically deriving the required versions from go.mod rather than requiring manual updates in the Makefile. See: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#envtest-version-automation-and-improved-test-binary-discovery Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
See: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#replace-exportloopref-with-copyloopvar-in-golangciyaml Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
See: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#add-lint-config-target-to-makefile-to-verify-linter-configuration Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
Upgrade to Go 1.23 and Kubernetes v0.32.1 dependencies See: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#upgrade-to-go-123-and-kubernetes-v0321-dependencies Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
Change webhooks implementation to be able to use controller-runtime v0.20.0+ See: - https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#you-must-change-your-webhooks-implementation-to-be-able-to-use-controller-runtime-v0200 - https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v4.3.0 Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
lucamarchiori
force-pushed
the
support-hidden-dashboard-sidebar
branch
3 times, most recently
from
48fb457 to
479c7d1
Compare
PR astarte-platform/astarte-dashboard#521 introduced the ability to hide the Astarte Dashboard sidebar by tweaking its configuration. This allows the dashboard to be more easily used as an embedded component. This commit adds an annotation to the Astarte Custom Resource (CR) that acts as a feature flag to enable or disable the sidebar display. This annotation is a temporary solution to support the feature until it is officially added to the Astarte CR specification under the Dashboard component section. If the annotation is not set, it defaults to false (the sidebar remains visible). No defaulting webhook has been configured to automatically populate this annotation on the Astarte CR. To hide the Dashboard sidebar, set the following on the Astarte CR: ```yaml annotations: api.astarte-platform.org/hide-dashboard-sidebar: "true" ``` Signed-off-by: Luca Marchiori <luca.marchiori@secomind.com>
lucamarchiori
force-pushed
the
support-hidden-dashboard-sidebar
branch
from
479c7d1 to
ef18217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR astarte-platform/astarte-dashboard#521 introduced the ability to hide the Astarte Dashboard sidebar by tweaking its configuration. This allows the dashboard to be more easily used as an embedded component.
This PR adds an annotation to the Astarte Custom Resource (CR) that acts as a feature flag to enable or disable the sidebar display.
This annotation is a temporary solution to support the feature until it is officially added to the Astarte CR specification under the Dashboard component section. If the annotation is not set, it defaults to false (the sidebar remains visible).
No defaulting webhook has been configured to automatically populate this annotation on the Astarte CR.
To hide the Dashboard sidebar, set the following on the Astarte CR: