AstarteExport: Add Support for Dynamic Cassandra Host/Port in Astarte Export#1050
Open
Jusuf95 wants to merge 1 commit intoastarte-platform:masterfrom
Open
AstarteExport: Add Support for Dynamic Cassandra Host/Port in Astarte Export#1050Jusuf95 wants to merge 1 commit intoastarte-platform:masterfrom
Jusuf95 wants to merge 1 commit intoastarte-platform:masterfrom
Conversation
Jusuf95
force-pushed
the
cassandra-env-vars
branch
from
c455bfa to
f45194b
Compare
Annopaolo
requested changes
Jan 27, 2025
Jusuf95
force-pushed
the
cassandra-env-vars
branch
from
f45194b to
3905d90
Compare
eddbbt
reviewed
Jan 29, 2025
eddbbt
reviewed
Jan 29, 2025
eddbbt
reviewed
Jan 29, 2025
Jusuf95
force-pushed
the
cassandra-env-vars
branch
from
3905d90 to
354d529
Compare
Jusuf95
force-pushed
the
cassandra-env-vars
branch
from
354d529 to
da9be2c
Compare
eddbbt
suggested changes
Jan 29, 2025
Contributor
eddbbt
left a comment
eddbbt
left a comment
There was a problem hiding this comment.
It is not completely wrong to accept a keyword list inside the iex shell and a string parameter outside with mix.task, but be sure that we're not overriding existent behaviors
Jusuf95
force-pushed
the
cassandra-env-vars
branch
from
da9be2c to
511a4ac
Compare
eddbbt
reviewed
Feb 7, 2025
- Modified export_realm_data/3 to accept db_host_and_port as an argument. - Set Cassandra host and port as env variables - Updated the run/1 function to reflect the new parameters for exporting. - Enhanced documentation to include the new db_host_and_port argument. - Updated README to reflect the changes in function usage and parameters. Signed-off-by: Jusuf <jusuf.avdic@secomind.com>
Jusuf95
force-pushed
the
cassandra-env-vars
branch
from
511a4ac to
a763aae
Compare
eddbbt
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancements to Astarte Export Functionality:
Cassandra.
Code Maintenance:
What this PR does / why we need it:
This change enhances the Astarte export process by allowing more flexible configuration of Cassandra connectivity, improving the function's ability to work with various environments and setups.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Please review the changes in export/export_realm_data/3 and run/1 to ensure the new parameters are correctly implemented and the documentation is accurate.
Does this PR introduce a user-facing change?
Additional documentation e.g. usage docs, diagrams, etc.: