Parallel workflows in Astarte#1418
Merged
noaccOS merged 1 commit intoastarte-platform:release-1.3from Jul 29, 2025
Merged
Conversation
eddbbt
force-pushed
the
dashboard_on_e2e
branch
7 times, most recently
from
f738298 to
ac41f00
Compare
eddbbt
force-pushed
the
dashboard_on_e2e
branch
3 times, most recently
from
8b38163 to
06c8ab2
Compare
eddbbt
force-pushed
the
dashboard_on_e2e
branch
17 times, most recently
from
c426842 to
6454986
Compare
eddbbt
force-pushed
the
dashboard_on_e2e
branch
17 times, most recently
from
ebe5ecc to
2e4880a
Compare
eddbbt
changed the title
eddbbt
changed the title
eddbbt
force-pushed
the
dashboard_on_e2e
branch
2 times, most recently
from
fc2eb4f to
6208c3c
Compare
noaccOS
reviewed
Jul 28, 2025
| E2E_MAIL_SUBJECT: "Subj: Astarte Notification" | ||
| run: mix run --no-halt | ||
| run: | | ||
| mix deps.get |
Collaborator
There was a problem hiding this comment.
isn't this done in the e2e-build workflow? doing it here would also mean no caching
Contributor
Author
There was a problem hiding this comment.
mhhh, I'll try to add a cache action also for this
Comment on lines
+5
to
+6
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
probably missing a format
Comment on lines
+16
to
+26
| - name: Cache Astarte E2E deps | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: tools/astarte_e2e/deps | ||
| key: e2e-deps-${{ env.otp_version }}-${{ env.elixir_version }}-${{ hashFiles(format('{0}{1}{2}', github.workspace, '/tools/astarte_e2e', '/mix.lock')) }} | ||
| - name: Cache Astarte E2E build | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: tools/astarte_e2e/_build | ||
| key: e2e-build-${{ env.otp_version }}-${{ env.elixir_version }} | ||
| - name: Cache Astarte E2E deps | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: tools/astarte_e2e/deps | ||
| key: e2e-build-${{ env.otp_version }}-${{ env.elixir_version }} | ||
| - uses: erlef/setup-beam@v1.15 |
Contributor
There was a problem hiding this comment.
There are two cache steps for tools/astarte_e2e/deps using different cache keys. Is this intentional, or could these be consolidated or clarified.
Contributor
Author
There was a problem hiding this comment.
indeed, a silly letfover, fixed
OmarBrbutovic
approved these changes
Jul 29, 2025
Dam-99
approved these changes
Jul 29, 2025
Contributor
Dam-99
left a comment
Dam-99
left a comment
There was a problem hiding this comment.
thx for removing the unused env from the astarte-build workflow🤙🏻
noaccOS
requested changes
Jul 29, 2025
Signed-off-by: Eddy Babetto <eddy.babetto@secomind.com>
noaccOS
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aim to make astarte build and e2e two different jobs, in order to reuse them with more flexibility in the future