test(dup): Extract Interface properties unset test from simple flow#1539
Draft
AliouneGaye21 wants to merge 1 commit intoastarte-platform:release-1.2from
Draft
test(dup): Extract Interface properties unset test from simple flow#1539AliouneGaye21 wants to merge 1 commit intoastarte-platform:release-1.2from
AliouneGaye21 wants to merge 1 commit intoastarte-platform:release-1.2from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #1539 +/- ##
===============================================
- Coverage 83.62% 83.53% -0.09%
===============================================
Files 290 290
Lines 6949 6949
===============================================
- Hits 5811 5805 -6
- Misses 1138 1144 +6 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
AliouneGaye21
changed the title
AliouneGaye21
requested review from
a team,
Annopaolo,
eddbbt and
noaccOS
and removed request for
a team
AliouneGaye21
force-pushed
the
dup_simple_flow_unset
branch
from
7c5fd6f to
0569b29
Compare
Annopaolo
requested changes
Oct 10, 2025
Collaborator
Annopaolo
left a comment
Annopaolo
left a comment
There was a problem hiding this comment.
Looks good, it just needs a rebase!
AliouneGaye21
force-pushed
the
dup_simple_flow_unset
branch
from
0569b29 to
0cd4192
Compare
noaccOS
reviewed
Oct 13, 2025
| # limitations under the License. | ||
| # | ||
|
|
||
| defmodule Astate.DataUpdaterPlant.UnsetTest do |
Collaborator
There was a problem hiding this comment.
why do we need a different module? unset is still a functionality of data updater
eddbbt
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the device disconnection logic from the monolithic
data_updater_test into its own dedicated test file.<!-- Thanks for sending a pull request! Here are some tips for you:
-->
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g. usage docs, diagrams, etc.: