Dup simple flow producer properties#1555
Draft
AliouneGaye21 wants to merge 3 commits intoastarte-platform:release-1.2from
Draft
Dup simple flow producer properties#1555AliouneGaye21 wants to merge 3 commits intoastarte-platform:release-1.2from
AliouneGaye21 wants to merge 3 commits intoastarte-platform:release-1.2from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #1555 +/- ##
===============================================
- Coverage 83.62% 83.47% -0.15%
===============================================
Files 290 290
Lines 6949 6949
===============================================
- Hits 5811 5801 -10
- Misses 1138 1148 +10
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
AliouneGaye21
requested review from
a team,
eddbbt and
frossq
and removed request for
a team
eddbbt
reviewed
Oct 24, 2025
| page = | ||
| Xandra.execute!(conn, prepared, %{"device_id" => device_id}, uuid_format: :binary) | ||
| # Let the process handle device's last message | ||
| Process.sleep(100) |
Contributor
Author
There was a problem hiding this comment.
yes, the processing of the last device message take a while.
Withot the delay, the next assertion will fail
AliouneGaye21
force-pushed
the
dup_simple_flow_producer_properties
branch
3 times, most recently
from
06f1e8f to
f24c7a9
Compare
eddbbt
approved these changes
Oct 30, 2025
AliouneGaye21
force-pushed
the
dup_simple_flow_producer_properties
branch
from
f24c7a9 to
35b342e
Compare
dedicated module
AliouneGaye21
force-pushed
the
dup_simple_flow_producer_properties
branch
from
35b342e to
01fdf9f
Compare
eddbbt
approved these changes
Oct 31, 2025
frossq
reviewed
Nov 14, 2025
| } | ||
| end | ||
|
|
||
| test "Unset values from interface properties", %{ |
Contributor
There was a problem hiding this comment.
Wrong test name, should recall the operation of setting properties list
frossq
reviewed
Nov 14, 2025
Comment on lines
+85
to
+90
|
|
||
| assert DataUpdater.handle_delete_volatile_trigger( | ||
| realm, | ||
| encoded_device_id, | ||
| volatile_changed_trigger_id | ||
| ) == :ok |
frossq
reviewed
Nov 14, 2025
Comment on lines
+92
to
+100
| # DataUpdater.handle_data( | ||
| # realm, | ||
| # encoded_device_id, | ||
| # "com.test.LCDMonitor", | ||
| # "/weekSchedule/10/start", | ||
| # <<>>, | ||
| # gen_tracking_id(), | ||
| # make_timestamp("2017-10-09T15:10:32+00:00") | ||
| # ) |
Contributor
There was a problem hiding this comment.
Needs to be enabled. Also, make sure that the property has been set before unsetting it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g. usage docs, diagrams, etc.: