Upgrade Elixir, OTP and runner image#164
Merged
Annopaolo merged 6 commits intoastarte-platform:masterfrom Jan 15, 2025
Merged
Conversation
eddbbt
approved these changes
Jan 10, 2025
Emina-M
force-pushed
the
upgrade-elixir-otp
branch
4 times, most recently
from
47b7702 to
34a56e2
Compare
Annopaolo
reviewed
Jan 15, 2025
|
|
||
| v when is_map(v) -> | ||
| Enum.reduce_while(v, {:ok, %{}}, fn {item_key, item_value}, {:ok, acc} -> | ||
| Enum.reduce_while(Map.to_list(v), {:ok, %{}}, fn {item_key, item_value}, {:ok, acc} -> |
Collaborator
There was a problem hiding this comment.
Nit: maps implement the Enumerable protocol, so there is no need to use to_list/1
Upgrade to Elixir 1.16.3 and OTP 24.3.4.17. Use Debian runner image. Adapt code for Cyanide 2.0 binaries. Signed-off-by: Emina Muminovic <emina.muminovic@secomind.com>
The :gettext compiler is no longer required in mix.exs file and is therefore removed. Signed-off-by: Emina Muminovic <emina.muminovic@secomind.com>
Mix.Config is deprecated and is therefore replaced with Config module. Signed-off-by: Emina Muminovic <emina.muminovic@secomind.com>
Logger.warn is deprecated and therefore replaced with Logger.warning Log level atom :warn for tests is replaced with :warning Signed-off-by: Emina Muminovic <emina.muminovic@secomind.com>
Application.get_env/3 is discouraged in the module body, therefore Application.compile_env/3 is used instead. Signed-off-by: Emina Muminovic <emina.muminovic@secomind.com>
Use underscore to avoid warning about unused variables. Signed-off-by: Emina Muminovic <emina.muminovic@secomind.com>
Emina-M
force-pushed
the
upgrade-elixir-otp
branch
from
34a56e2 to
2c13c5d
Compare
Annopaolo
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.