Open
Conversation
Annopaolo
reviewed
Feb 5, 2025
lib/astarte_flow.ex
Outdated
Comment on lines
-57
to
+59
| import Astarte.FlowWeb.ErrorHelpers | ||
| import Astarte.FlowWeb.Gettext | ||
| alias Astarte.FlowWeb.Router.Helpers, as: Routes | ||
| # Include shared imports and aliases for views | ||
| unquote(view_helpers()) |
Collaborator
There was a problem hiding this comment.
Why the need for quoting/unquoting imports and aliases here?
Contributor
Author
There was a problem hiding this comment.
Most of the changes in this PR follow scaffolding generated with phoenix 1.6.16 generator. The goal is to be consistent with generated code, so future upgrades are easier. If it's not something we adhere to, I can remove this change.
| app: :astarte_flow, | ||
| version: "0.1.0", | ||
| elixir: "~> 1.7", | ||
| elixir: "~> 1.12", |
Collaborator
There was a problem hiding this comment.
Shouldn't this be 1.17 now?
Contributor
Author
There was a problem hiding this comment.
Similar answer to previous comment. You can take a look at the versions diff here
Upgrade Phoenix scaffolding from version 1.5.3 to 1.6.16 using generator: mix phx.new astarte_flow --app astarte_flow --module Astarte.Flow \ --no-assets --no-ecto --no-html --no-live --no-mailer --no-dashboard Signed-off-by: Emina Muminovic <emina.muminovic@secomind.com>
Replace `astarte_streams` with `astarte_flow`. Signed-off-by: Emina Muminovic <emina.muminovic@secomind.com>
Autogenerated with `mix deps.update --all` Major changes: telemetry_metrics 0.6 => 1.1.0 telemetry_metrics_prometheus_core 0.4 => 1.2.1 Signed-off-by: Emina Muminovic <emina.muminovic@secomind.com>
Emina-M
force-pushed
the
phx-1.6-upgrade
branch
from
47ee7f1 to
b001c6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.5.3to1.6.16using generator:.gitignore