Refactor astartectl utils validate interfaces, triggers#278
Merged
matt-mazzucato merged 2 commits intoastarte-platform:masterfrom Jan 29, 2025
Merged
Conversation
matt-mazzucato
requested changes
Jan 29, 2025
Collaborator
matt-mazzucato
left a comment
matt-mazzucato
left a comment
There was a problem hiding this comment.
LGTM. Can you please add a minimal entry to the changelog?
Add validation confirmation messages for Astarte Interface and Trigger Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
osmanhadzic
force-pushed
the
update-confirmation-messages
branch
from
e2bfe44 to
9291ae7
Compare
Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
osmanhadzic
force-pushed
the
update-confirmation-messages
branch
from
9291ae7 to
826933f
Compare
matt-mazzucato
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd/utilspackage to improve user feedback during validation processes. The most important changes are the addition of print statements to confirm the validity of interfaces and triggers.Improvements to user feedback:
cmd/utils/interfaces.go: Added a print statement to confirm when an interface is valid.cmd/utils/triggers.go: Added a print statement to confirm when a trigger is valid.Add validation confirmation messages for Astarte Interface and Trigger