Skip to content

make rendering of substeps as separate page optional #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make rendering of substeps as separate page optional #174

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02364e7
make rendering of substeps as separate page optional
rbedemann Jan 20, 2019
d7f82d3
change scale to fit page better
rbedemann Jan 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions decktape.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ async function exportSlide(plugin, page, printer, context) {
printBackground : true,
pageRanges : '1',
displayHeaderFooter : false,
scale: 1.5
Copy link
Owner

@astefanutti astefanutti Jan 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's related to #107 and specific to Impress. I would suggest we add an option and change the default value for Impress instead of hard-coding the value for all presentation frameworks.

});
printSlide(printer, new BufferReader(buffer), context);
context.exportedSlides++;
Expand Down