Skip to content

Conversation

@nicojs
Copy link
Contributor

@nicojs nicojs commented Jun 20, 2024

Update all dependencies. This will remove the audit warnings when installing decktape.

Closes #334

@nicojs
Copy link
Contributor Author

nicojs commented Jun 20, 2024

Commit 8f7fe3b also includes an actual bugfix. It ensures that puppeteer waits for all web fonts to be loaded on the slide.

I've included this, because the build failed with a wrong screenshot match. I'll separate it into a separate PR: #337 .

I don't know why the docker build "buildx" is failing. 😢

@astefanutti
Copy link
Owner

I don't know why the docker build "buildx" is failing. 😢

That's the chromium package that needs to be updated:

3.467 ERROR: unable to select packages:
3.474   chromium-126.0.6478.61-r0:
3.475     breaks: world[chromium=122.0.6261.94-r0]

I can take care of it before cutting the next release.

@astefanutti
Copy link
Owner

@nicojs do you want to remove commit 3281d79 and continue the discussion in #337?

@nicojs
Copy link
Contributor Author

nicojs commented Jul 3, 2024

Done. Feel free to Squash merge :)

@astefanutti astefanutti merged commit 574c643 into astefanutti:master Jul 3, 2024
@nicojs nicojs deleted the chore/deps branch July 3, 2024 07:09
@astefanutti
Copy link
Owner

Thanks a ton!

@nicojs
Copy link
Contributor Author

nicojs commented Jul 4, 2024

Can we create a new release?

@astefanutti
Copy link
Owner

Yes, I plan to do it in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit warning when installing decktape 3.4.0

2 participants