Skip to content

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Oct 2, 2024

We need conditional build suffix support for the free-threaded builds.

Tested with:

just release-dry-run <token> f9203c323d8a4d10e3c64f29356c96f0e3907971 20241002

Comment on lines 80 to +85
let macos_suffixes = vec!["debug", "pgo", "pgo+lto"];
let macos_suffixes_313 = vec![
"freethreaded+debug",
"freethreaded+pgo",
"freethreaded+pgo+lto",
];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be static so we can't derive it from the above list without a more invasive change.

@zanieb zanieb requested a review from charliermarsh October 2, 2024 18:13
@zanieb zanieb merged commit 09bc4f5 into main Oct 2, 2024
332 of 333 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants