ci: enable PGO on x86-64-v4 #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub Actions x86-64 runners are using ancient Azure instances that lack AVX-512. As a result we can't run x86-64-v4 binaries. As a result we can't perform PGO/BOLT nor run tests using the built interpreter. We recently adopted custom runners. Whatever hardware they are using under the hood appears to support AVX-512 and therefore the x86-64-v4 instruction set. So we're able to enable PGO and running tests. This will theoretically deliver performance wins for the x86-64-v4 builds. But I haven't performed comprehensive testing.
indygreg
force-pushed
the
gps/x86-64-v4-pgo
branch
from
1128199 to
56aa8ba
Compare
|
To my pleasant surprise, this appeared to just work. I'm not sure what the underlying hardware is, but it appears to be sufficiently modern to allow us to have nice things. |
|
Sweet! |
zanieb
approved these changes
Jan 2, 2025
zanieb
added a commit
that referenced
this pull request
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub Actions x86-64 runners are using ancient Azure instances
that lack AVX-512. As a result we can't run x86-64-v4 binaries. As
a result we can't perform PGO/BOLT nor run tests using the built
interpreter.
We recently adopted custom runners. Whatever hardware they are
using under the hood appears to support AVX-512 and therefore
the x86-64-v4 instruction set. So we're able to enable PGO
and running tests.
This will theoretically deliver performance wins for the x86-64-v4
builds. But I haven't performed comprehensive testing.