Patch 3.14.0a5 PGO on Windows amd64 #526
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Feb 12, 2025
| # We should be able to drop this patch in 3.14.0a6 | ||
| exec_and_log( | ||
| [ | ||
| "patch", |
Member
Author
There was a problem hiding this comment.
Presuming patch isn't available here and is why we don't have Windows patchfiles, but we'll see. Will follow with another approach if so.
There was a problem hiding this comment.
git apply might work too if you have git.
|
Seems like there's no need to apply the patch anymore. Hugo re-uploaded the 3.14a5 FTP tarballs with the MSVC patch applied. |
Contributor
|
Yep, the release needed three goes due to this Windows PGO bug and I accidentally uploaded the tarballs from the second attempt. Sorry about that! |
Member
Author
|
Thank goodness, saves me even more time <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/cpython#130004